Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role backend implementation #467

Merged
merged 15 commits into from
Aug 4, 2024
Merged

Role backend implementation #467

merged 15 commits into from
Aug 4, 2024

Conversation

tanbirali
Copy link
Contributor

closes #435

📑 Description

This PR supports the fetching information about a Role
The new types are added with ref to the PR #259

✅ Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

ℹ Additional context

@tanbirali tanbirali requested a review from a team as a code owner July 24, 2024 13:03
@tanbirali
Copy link
Contributor Author

Made the requested changes, do have a look.

petar-cvit
petar-cvit requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add role rules to the object. mapRole function doesn't add any Role specific info to the response

cyclops-ctrl/internal/cluster/k8sclient/client.go Outdated Show resolved Hide resolved
petar-cvit
petar-cvit reviewed Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanbirali can you run go fmt ./... from cyclops-ctrl

petar-cvit
petar-cvit requested changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanbirali, left one more comment, but rest of the PR looks good 😄

cyclops-ctrl/internal/cluster/k8sclient/client.go Outdated Show resolved Hide resolved
petar-cvit
petar-cvit approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanbirali 🧡

@petar-cvit petar-cvit merged commit 45fc534 into cyclops-ui:main Aug 4, 2024
1 check passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petar-cvit petar-cvit petar-cvit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Role Backend Implementation
2 participants
@tanbirali @petar-cvit