Improve logging #2437
Merged
Improve logging #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
approved these changes
Oct 4, 2017
lib/cylc/scheduler.py
Outdated
| @@ -1308,8 +1313,8 @@ def run(self): | |||
| self.suite_db_mgr.put_task_pool(self.pool) | |||
| self.update_state_summary() # Will reset cylc.flags.iflag | |||
|
|
|||
| # Process queued operations for each task proxy | |||
| self.process_queued_task_operations() | |||
| # Process suite DB queue | |||
There was a problem hiding this comment.
An unnecessary comment, given the name of the method on next line!
matthewrmshin
force-pushed
the
improve-log
branch
from
4124d26
to
1dfe93c
Compare
|
Pointless comment removed. Branch rebased. |
oliver-sanders
approved these changes
Oct 19, 2017
|
There are three unused |
Avoid sending items to OUT from a running suite. Ensure that the verbosity level makes sense for ERR.
matthewrmshin
force-pushed
the
improve-log
branch
from
1dfe93c
to
ab2fa6c
Compare
|
Removed unused |
This was referenced Oct 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid sending items to OUT from a running suite.
Ensure that the verbosity level makes sense for ERR. (E.g.
ERR.debugnever actually did anything before!)