Replace simplejson with json in standard library #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
commented
Oct 20, 2017
| @@ -20,7 +20,7 @@ | |||
| # Test "rose suite-restart", basic usage. | |||
| #------------------------------------------------------------------------------- | |||
| . "$(dirname "$0")/test_header" | |||
| tests 4 | |||
| tests 3 | |||
There was a problem hiding this comment.
Fixes test failure caused by cylc/cylc-flow#2437.
matthewrmshin
commented
Oct 20, 2017
|
|
||
| <p><dfn>minimum version required:</dfn> | ||
| 2.2.1.</p> | ||
| 2.4.2.</p> |
There was a problem hiding this comment.
This is to make it consistent with the Cylc HTTPS client.
They are the same module from Python 2.6+.
matthewrmshin
force-pushed
the
remove-simplejson-dependency
branch
from
d3b1538
to
a2ff66c
Compare
oliver-sanders
approved these changes
Oct 20, 2017
|
@dvalters please do a quick sanity check. |
This was referenced Oct 25, 2017
dvalters
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are the same module from Python 2.6+. This change removes this unnecessary external dependency.