Fix job polling for SGE #2462
Merged
Fix job polling for SGE #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Failing codacy - line 66 has trailing white space.) |
hjoliver
approved these changes
Oct 30, 2017
There was a problem hiding this comment.
Looks good as far as I can tell - as I can't test SGE here! Thanks @RosalynHatcher - if you could just fix the trivial whitespace error before we merge this...
|
@hjoliver, @matthewrmshin - whitespace error fixed. |
|
Latest Travis CI failure unrelated. (It is because |
matthewrmshin
approved these changes
Oct 30, 2017
|
@matthewrmshin - any reason not to merge this now, given the new errors are verified as unrelated to this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2439
The default
qstat <jobid>is no longer valid syntax for SGE. There is no option to query a specific job id and return tabular output which cylc is currently relying on.Add
get_poll_many_cmdmethod to sge handler. This will useqstatwith no arguments to list the user's jobs in the required format and then the code already inbatch_sys_manager._jobs_poll_batch_sys()will check that any of the submitted or running jobs is the one requested.