test-battery: pycodestyle #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Would this work on our site?) |
|
No, hence I have left the |
oliver-sanders
force-pushed
the
pycodestyle
branch
from
c302bfd
to
cf3dbc8
Compare
oliver-sanders
commented
Oct 25, 2017
| @@ -109,7 +109,7 @@ def index(self, *_): | |||
| """Provide the index page.""" | |||
| try: | |||
| return self._render() | |||
| except: | |||
| except (KeyError, AttributeError, jinja2.exceptions.TemplateError): | |||
There was a problem hiding this comment.
jinja2.exceptions.TemplateError might be sufficient here?
There was a problem hiding this comment.
Most likely. The client will get a 500 in the worst case.
oliver-sanders
commented
Oct 25, 2017
| self.event_handler.contexts.get(uuid).handle.close() | ||
| except: | ||
| self.event_handler.contexts[uuid].handle.close() | ||
| except (KeyError, IOError, AttributeError): |
There was a problem hiding this comment.
possibly TypeError as well?
|
./t/rose-suite-restart/02-basic.t fixed by #2123 |
This was referenced Oct 30, 2017
matthewrmshin
approved these changes
Oct 30, 2017
|
@stevewardle do you mind doing a sanity check for us? |
|
Looks perfectly reasonable to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python
pep8package has been renamedpycodestyleto avoid confusion.This fixes
t/syntax/00-lib.twhich will fail with newer versions ofpep8due to a depreciation notice.