Fix check-versions and other tests #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewrmshin
force-pushed
the
fix-check-versions
branch
11 times, most recently
from
86ba3e6
to
c561404
Compare
Update to use `cylc.task_remote_mgr` instead of `cylc.host_select`. Use `git describe --always` to ensure it does not fail.
matthewrmshin
force-pushed
the
fix-check-versions
branch
from
c561404
to
b246f7e
Compare
|
This should be good enough to fix the current Travis CI breakages. |
This was referenced Jan 16, 2018
hjoliver
requested changes
Jan 17, 2018
bin/cylc-check-versions
Outdated
| user = config.get_config(['runtime', name, 'remote', 'owner']) | ||
| account_set.add(( | ||
| config.get_config(['runtime', name, 'remote', 'owner']), | ||
| config.get_config(['runtime', name, 'remote', 'host']))) |
There was a problem hiding this comment.
Lines removed.
sadielbartholomew
approved these changes
Jan 17, 2018
There was a problem hiding this comment.
Looks good! Approving, though I have observed that sleep(1) would be sufficient for line 88 of 'bin/cylc-check-versions' and also the change at lines 63-64 of this same file seems unnecessary as SuiteSrvFilesManager() is only invoked one further time on line 76 so assignment to a variable of similar length has no benefit as far as I can tell.
hjoliver
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use
cylc.task_remote_mgrinstead ofcylc.host_select.Ensure we have the correct package to make documentation.
Use
git describe --alwaysto prevent it from failing.Fix test broken by #2468. Fix tests due to recent change to Travis CI? (Package for LaTex and behaviour of
git describe.)