Fix reload with stop point #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Travis CI failure will be fixed by #2539.) |
Reload will no longer reset existing stop point.
matthewrmshin
force-pushed
the
fix-reload-stop-point-issue
branch
from
a26af7b
to
57ebff0
Compare
sadielbartholomew
approved these changes
Jan 23, 2018
| 2016-07-08T14:53:12+01 INFO - Initial point: 1 | ||
| 2016-07-08T14:53:12+01 INFO - Final point: 5 | ||
| 2016-07-08T14:53:12+01 INFO - [set-stop-point.1] -triggered off [] | ||
| 2016-07-08T14:53:19+01 INFO - [reload.1] -triggered off ['set-stop-point.1'] |
There was a problem hiding this comment.
This highlights the usefulness of a revamped suite log as outlined in #1032 - with a line (or a note in the 'stopping' notification near the end) conveying the setting of a stop point via a cylc stop <suite name> <stop point> command it would be clear the suite doesn't shutdown erroneously before the FCP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload will no longer reset existing stop point. This is one way to fix #2535 and fix #2536.