Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure queued deltas are published before shutdown #5098

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 25, 2022

Closes #5092

Fix bug where the final deltas were not being published before stopping the WorkflowRuntimeServer at shutdown

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

@MetRonnie MetRonnie added the bug Something is wrong :( label Aug 25, 2022
@MetRonnie MetRonnie added this to the 8.0.2 milestone Aug 25, 2022
@MetRonnie MetRonnie self-assigned this Aug 25, 2022
@MetRonnie MetRonnie force-pushed the publisher branch 2 times, most recently from bc69449 to 5d8b4d2 Compare August 25, 2022 16:28
@MetRonnie MetRonnie linked an issue Aug 30, 2022 that may be closed by this pull request
@oliver-sanders
Copy link
Member

aeaeee9 Looks good to me. The tidying and shutdown fiddling (unrelated to the bugfix) should go onto the 8.1.0 milestone (can cherrypick onto the merge PR or whatever).

@MetRonnie
Copy link
Member Author

I've removed most of that from this branch, but kept the improved error logging and fixes to a few type annotations that were incorrect

Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oliver-sanders oliver-sanders merged commit ca2ab09 into cylc:8.0.x Sep 7, 2022
@MetRonnie MetRonnie deleted the publisher branch September 12, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task status not getting through to UI Server before shutdown?
3 participants