Simplify WorkflowRuntimeServer stop logic
#5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| self._start_sequence(*args, **kwargs) | ||
|
|
||
| def _start_sequence(self, *args, **kwargs): |
There was a problem hiding this comment.
The legacy reason for this was the thread use to be started from here.
dwsutherland
approved these changes
Sep 27, 2022
| port: Union[int, str] = None, | ||
| context: object = None, | ||
| srv_public_key_loc: str = None, | ||
| topics: Iterable[bytes] = None |
There was a problem hiding this comment.
I never really liked the double indentation .. But the linter use to pull us up otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some tidying & adding type annotations.
This was split off from #5098
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included (invisible to users)