Fix execution time limit polling intervals [Cylc 7] #5751
Conversation
wxtim
force-pushed
the
fix.execution_time_limit_polling_intervals
branch
2 times, most recently
from
5e0860b
to
74ce932
Compare
wxtim
force-pushed
the
fix.execution_time_limit_polling_intervals
branch
from
74ce932
to
b6602d2
Compare
wxtim
changed the title
|
|
||
| # Total timeout after adding execution time limit polling | ||
| # intervals: | ||
| timeout = (time_limit + sum(time_limit_delays)) |
There was a problem hiding this comment.
This line seems to be missing from the Cylc 8 branch?
There was a problem hiding this comment.
It was removed here: #4863 - @dpmatthews is it sane to backport this change?
[edit]
Dave said yes on Teams
There was a problem hiding this comment.
Actually, this bit is a change in behaviour rather than a bug fix. I suggest we leave it unchanged in Cylc 7.
There was a problem hiding this comment.
2. Prevent task events manager modifying the list of
execution time limit polling intervalsinglbl_cfg, which was causing the first polling interval after the execution time limit to increment every time this code was run.
I'm not seeing how the changes here address this, could you explain?
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
No, because they don't. Good Spot. 🐆 |
wxtim
force-pushed
the
fix.execution_time_limit_polling_intervals
branch
from
c548386
to
e6efa26
Compare
Fixes 2 bugs without issues reports.
execution time limit polling intervalsinglbl_cfg, which was causing the first polling interval after the execution time limit to increment every time this code was run.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.