Fix execution time limit polling intervals [cylc 8] #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.execution_retry_delays
branch
from
b5d3f11
to
d78a682
Compare
wxtim
commented
Oct 4, 2023
| if delays: | ||
| size = int((time_limit - sum(delays)) / delays[-1]) | ||
| delays.extend([delays[-1]] * size) | ||
| time_limit_delays[0] += time_limit - sum(delays) |
There was a problem hiding this comment.
The last member of the list is repeated.
if len(time_limit_delays) == 1 then all subsequent delays are not the set execution time limit polling intervals, but that value + the remainder of the execution polling intervals under the time limit.
wxtim
commented
Oct 4, 2023
cylc/flow/task_events_mgr.py
Outdated
Comment on lines
1665
to
1669
| if len(time_limit_polling_intervals) > 1: | ||
| time_limit_polling_intervals[0] += time_limit - sum(delays) | ||
| else: | ||
| delays.append( | ||
| time_limit_polling_intervals[0] + time_limit - sum(delays)) |
There was a problem hiding this comment.
This is the bug fix - the rest is refactoring for easier testing.
- time_limit_polling_intervals[0] += time_limit - sum(delays)
wxtim
force-pushed
the
fix.execution_retry_delays
branch
from
322d2aa
to
e7f932d
Compare
wxtim
force-pushed
the
fix.execution_retry_delays
branch
from
e7f932d
to
7bee764
Compare
8 tasks
wxtim
changed the title
MetRonnie
reviewed
Oct 4, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
Kicking tests |
MetRonnie
approved these changes
Oct 5, 2023
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
oliver-sanders
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to a bug not otherwise recorded:
Bug description
If the sum of
execution polling intervals<execution time limitthe remainder should be added to the first, but only the firstexecution time limit polling interval. Currently the remainder is always added to the first items in the list ofexecution time limit polling intervals.The last item in the list of
execution time limit polling intervalsis repeated until the final itask timeout. At the moment if we set only one item inexecution time limit polling intervalsthen every polling interval isexecution time limit polling intervals[0] + remainder.Example
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.