-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add internal 18.17.1 chrome 128 and firefox 130 image and update factory browsers #1210
chore: add internal 18.17.1 chrome 128 and firefox 130 image and update factory browsers #1210
Conversation
…nally updates browsers in docker factory for end users.
26662da
to
f272473
Compare
|
||
# Cypress versions: https://www.npmjs.com/package/cypress | ||
CYPRESS_VERSION='13.14.2' | ||
|
||
# Edge versions: https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/ | ||
EDGE_VERSION='128.0.2739.63-1' | ||
EDGE_VERSION='128.0.2739.67-1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't find revision 79 for some reason in the stable pool. will try again next week during the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it as well, but the mirror seems to believe its unavailable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not critical if Edge 128.0.2739.79-1
isn't fully available. GitHub runners are currently using 128.0.2739.67
.
|
||
**Note:** this image uses the `root` user. You might want to switch to non-root user like `node` when running this container for security | ||
|
||
**Note:** Currently, the linux/arm64 build of this image does not contain any browsers except Electron. See https://github.com/cypress-io/cypress-docker-images/issues/695 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The issue Add Arm browsers to
linux/arm64
Docker images #695 is now closed.
A better place for current status is https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this comment yesterday. reference should now be up to date
echo "On Arm, non-Electron browsers are not available, because browser vendors are not yet building for Linux arm64." | ||
echo "You must use the built-in Electron browser (--browser electron) to run Cypress or find and install unofficial Arm binary builds." | ||
echo | ||
echo "More details and links to upstream issues for Chrome, Firefox, and Edge can be found at Cypress's issue tracker:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above
https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice! Going to try and tweak the image then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misunderstood. For some reason I thought a few of the arm browsers were available 🥴 . I have the global-profile updated in 42eb576
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the arm64
browsers are available as Debian packages. You just can't select the version you want, so they're not suitable for selection and installation through the .env
/ factory
process.
You can however install with apt-get install
… version is not an argument we control AFAIK
updating the git version in the |
If Debian puts out a git update, then we pick it up on the fly with I'm not sure why CircleCI is checking for this, but it does mean that we get surprised from time to time. CircleCI should probably be updated separately as it's a general issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments already in-line.
|
…nally updates browsers in docker factory for end users.
…om:cypress-io/cypress-docker-images into chore/add_chrome_128_ff_130_internal_image
58097a0
to
092309a
Compare
Additionally updates browsers in docker factory for end users.
NOTE: the internal image
cypress/browsers-internal:node18.17.1-chrome128-ff130
is published manually.