Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add internal 18.17.1 chrome 128 and firefox 130 image and update factory browsers #1210

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

AtofStryker
Copy link
Contributor

Additionally updates browsers in docker factory for end users.

NOTE: the internal image cypress/browsers-internal:node18.17.1-chrome128-ff130 is published manually.

@AtofStryker AtofStryker changed the title chore: add internal 18.17.1 chrome 128 and firefox 130 image. chore: add internal 18.17.1 chrome 128 and firefox 130 image and update factory browsers Sep 16, 2024
@AtofStryker AtofStryker self-assigned this Sep 16, 2024
…nally updates browsers in docker factory for end users.
@AtofStryker AtofStryker force-pushed the chore/add_chrome_128_ff_130_internal_image branch from 26662da to f272473 Compare September 16, 2024 15:17

# Cypress versions: https://www.npmjs.com/package/cypress
CYPRESS_VERSION='13.14.2'

# Edge versions: https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/
EDGE_VERSION='128.0.2739.63-1'
EDGE_VERSION='128.0.2739.67-1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find revision 79 for some reason in the stable pool. will try again next week during the release

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it as well, but the mirror seems to believe its unavailable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not critical if Edge 128.0.2739.79-1 isn't fully available. GitHub runners are currently using 128.0.2739.67.


**Note:** this image uses the `root` user. You might want to switch to non-root user like `node` when running this container for security

**Note:** Currently, the linux/arm64 build of this image does not contain any browsers except Electron. See https://github.com/cypress-io/cypress-docker-images/issues/695 for more information.
Copy link
Collaborator

@MikeMcC399 MikeMcC399 Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this comment yesterday. reference should now be up to date

echo "On Arm, non-Electron browsers are not available, because browser vendors are not yet building for Linux arm64."
echo "You must use the built-in Electron browser (--browser electron) to run Cypress or find and install unofficial Arm binary builds."
echo
echo "More details and links to upstream issues for Chrome, Firefox, and Edge can be found at Cypress's issue tracker:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! Going to try and tweak the image then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misunderstood. For some reason I thought a few of the arm browsers were available 🥴 . I have the global-profile updated in 42eb576

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the arm64 browsers are available as Debian packages. You just can't select the version you want, so they're not suitable for selection and installation through the .env / factory process.

You can however install with apt-get install

… version is not an argument we control AFAIK
@AtofStryker
Copy link
Contributor Author

updating the git version in the test-factory-all-included. Looks like the base image implicitly updated the git version from 2.39.2 to 2.39.5 which we do not control directory AFAIK. This is also failing in master

@MikeMcC399
Copy link
Collaborator

updating the git version in the test-factory-all-included. Looks like the base image implicitly updated the git version from 2.39.2 to 2.39.5 which we do not control directory AFAIK. This is also failing in master

If Debian puts out a git update, then we pick it up on the fly with apt-get update / apt-get upgrade like any other updates.

I'm not sure why CircleCI is checking for this, but it does mean that we get surprised from time to time.

CircleCI should probably be updated separately as it's a general issue.

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments already in-line.

@MikeMcC399
Copy link
Collaborator

@AtofStryker

updating the git version in the test-factory-all-included. Looks like the base image implicitly updated the git version from 2.39.2 to 2.39.5 which we do not control directory AFAIK. This is also failing in master

  • I submitted ci: relax hard-coded version check for git #1211 to remove the hard-coded git version check.

  • It appears that the git version does not change often, however having it hard-coded sets the workflow up to break unexpectedly and prevents generating an image based on another image, like debian:11, if that were ever required.

  • The version check was added because at one point git was accidently removed. The workflow still checks that git is installed and that fulfils the needs in a more robust way.

@AtofStryker AtofStryker force-pushed the chore/add_chrome_128_ff_130_internal_image branch from 58097a0 to 092309a Compare September 17, 2024 21:53
@AtofStryker AtofStryker merged commit 373c5bc into master Sep 17, 2024
31 checks passed
@AtofStryker AtofStryker deleted the chore/add_chrome_128_ff_130_internal_image branch September 17, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants