Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add internal 18.17.1 chrome 128 and firefox 130 image and update factory browsers #1210

Merged
merged 7 commits into from
Sep 17, 2024
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
# build this image with command
# docker build -t cypress/browsers-internal:node18.17.1-chrome128-ff130 --platform linux/amd64 .
#
FROM cypress/base-internal:18.17.1

USER root

RUN node --version

COPY ./global-profile.sh /tmp/global-profile.sh
RUN cat /tmp/global-profile.sh >> /etc/bash.bashrc && rm /tmp/global-profile.sh

# Install dependencies
RUN apt-get update && \
apt-get install -y \
fonts-liberation \
git \
libcurl4 \
libcurl3-gnutls \
libcurl3-nss \
xdg-utils \
wget \
curl \
# chrome dependencies
libu2f-udev \
# firefox dependencies
bzip2 \
# add codecs needed for video playback in firefox
# https://github.com/cypress-io/cypress-docker-images/issues/150
mplayer \
\
# clean up
&& rm -rf /var/lib/apt/lists/* \
&& apt-get clean

# install libappindicator3-1 - not included with Debian 11
RUN wget --no-verbose /usr/src/libappindicator3-1_0.4.92-7_amd64.deb "http://ftp.us.debian.org/debian/pool/main/liba/libappindicator/libappindicator3-1_0.4.92-7_amd64.deb" && \
dpkg -i /usr/src/libappindicator3-1_0.4.92-7_amd64.deb ; \
apt-get install -f -y && \
rm -f /usr/src/libappindicator3-1_0.4.92-7_amd64.deb

# install Chrome browser
RUN node -p "process.arch === 'arm64' ? 'Not downloading Chrome since we are on arm64: https://crbug.com/677140' : process.exit(1)" || \
(wget --no-verbose -O /usr/src/google-chrome-stable_current_amd64.deb "http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_128.0.6613.137-1_amd64.deb" && \
dpkg -i /usr/src/google-chrome-stable_current_amd64.deb ; \
apt-get install -f -y && \
rm -f /usr/src/google-chrome-stable_current_amd64.deb)

# "fake" dbus address to prevent errors
# https://github.com/SeleniumHQ/docker-selenium/issues/87
ENV DBUS_SESSION_BUS_ADDRESS=/dev/null

# install Firefox browser
RUN node -p "process.arch === 'arm64' ? 'Not downloading Firefox since we are on arm64: https://bugzilla.mozilla.org/show_bug.cgi?id=1678342' : process.exit(1)" || \
(wget --no-verbose -O /tmp/firefox.tar.bz2 https://download-installer.cdn.mozilla.net/pub/firefox/releases/130.0.1/linux-x86_64/en-US/firefox-130.0.1.tar.bz2 && \
tar -C /opt -xjf /tmp/firefox.tar.bz2 && \
rm /tmp/firefox.tar.bz2 && \
ln -fs /opt/firefox/firefox /usr/bin/firefox)

# versions of local tools
RUN echo " node version: $(node -v) \n" \
"npm version: $(npm -v) \n" \
"yarn version: $(yarn -v) \n" \
"debian version: $(cat /etc/debian_version) \n" \
"Chrome version: $(google-chrome --version) \n" \
"Firefox version: $(firefox --version) \n" \
"Edge version: n/a \n" \
"git version: $(git --version) \n" \
"whoami: $(whoami) \n"

# a few environment variables to make NPM installs easier
# good colors for most applications
ENV TERM=xterm
# avoid million NPM install messages
ENV npm_config_loglevel=warn
# allow installing when the main user is root
ENV npm_config_unsafe_perm=true
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# cypress/browsers-internal:node18.17.1-chrome128-ff130

A complete image with all operating system dependencies for Cypress, and Chrome 128.0.6613.137-1, Firefox 130.0.1 browsers.

NOTE: This image is intended for internal use with https://github.com/cypress-io/cypress. It contains a few differences from the factory, such as:

#### Dependency Additions

- curl
- build-essentials (to contain `make` and a few other dependencies)

#### Env variables

- Does not contain the `CACHE_FOLDER` and `FACTORY_DEFAULT_NODE_VERSION` env variables to keep unit tests non environment specific

[Dockerfile](Dockerfile)

**Note:** this image uses the `root` user. You might want to switch to non-root user like `node` when running this container for security

**Note:** Currently, the linux/arm64 build of this image does not contain any browsers except Electron. See https://github.com/cypress-io/cypress-docker-images/issues/695 for more information.
Copy link
Collaborator

@MikeMcC399 MikeMcC399 Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this comment yesterday. reference should now be up to date

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
set e+x

LOCAL_NAME=cypress/browsers-internal:node18.17.1-chrome128-ff130
echo "Building $LOCAL_NAME"
docker build -t $LOCAL_NAME .
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
if [[ "$(uname -a)" = *"arm"* || "$(uname -a)" = *"aarch64"* ]]; then
printf "\e[31m" # red
echo "Warning: You are using the beta Arm build of a cypress/browsers or cypress/included image."
echo
echo "On Arm, non-Electron browsers are not available, because browser vendors are not yet building for Linux arm64."
echo "You must use the built-in Electron browser (--browser electron) to run Cypress or find and install unofficial Arm binary builds."
echo
echo "More details and links to upstream issues for Chrome, Firefox, and Edge can be found at Cypress's issue tracker:"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! Going to try and tweak the image then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misunderstood. For some reason I thought a few of the arm browsers were available 🥴 . I have the global-profile updated in 42eb576

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the arm64 browsers are available as Debian packages. You just can't select the version you want, so they're not suitable for selection and installation through the .env / factory process.

You can however install with apt-get install

echo " https://github.com/cypress-io/cypress-docker-images/blob/master/README.md#browsers"
printf "\e[0m" # reset
fi
4 changes: 2 additions & 2 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ jobs:
name: check git version
command: |
ACTUAL_VERSION=$(docker compose run test-factory-all-included git --version)
if [ "git version 2.39.2" != "${ACTUAL_VERSION}" ]; then
echo "Version mismatch, git package version: git version 2.39.2 != ${ACTUAL_VERSION}"
if [ "git version 2.39.5" != "${ACTUAL_VERSION}" ]; then
echo "Version mismatch, git package version: git version 2.39.5 != ${ACTUAL_VERSION}"
exit 1;
fi
echo "Version ${ACTUAL_VERSION} confirmed"
Expand Down
6 changes: 3 additions & 3 deletions factory/.env
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ NODE_VERSION="${FACTORY_DEFAULT_NODE_VERSION}"
FACTORY_VERSION='4.2.0'

# Chrome versions: https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable
CHROME_VERSION='128.0.6613.119-1'
CHROME_VERSION='128.0.6613.137-1'

# Cypress versions: https://www.npmjs.com/package/cypress
CYPRESS_VERSION='13.14.2'

# Edge versions: https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/
EDGE_VERSION='128.0.2739.63-1'
EDGE_VERSION='128.0.2739.67-1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find revision 79 for some reason in the stable pool. will try again next week during the release

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it as well, but the mirror seems to believe its unavailable?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not critical if Edge 128.0.2739.79-1 isn't fully available. GitHub runners are currently using 128.0.2739.67.


# Firefox versions: https://download-installer.cdn.mozilla.net/pub/firefox/releases/
FIREFOX_VERSION='130.0'
FIREFOX_VERSION='130.0.1'

# Yarn versions: https://www.npmjs.com/package/yarn and
# https://classic.yarnpkg.com/latest-version
Expand Down