Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugins section id no whitespace #5299

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix: plugins section id no whitespace #5299

merged 1 commit into from
Jun 12, 2023

Conversation

MikeMcC399
Copy link
Contributor

This PR ensures that h2 section ids generated for the Plugins list conform to HTML rules which disallow whitespace in an id attribute.

For instance, the Section "Development Tools" was generated as <h2 id="Development Tools">, which is illegal due to the embedded whitespace between the two words.

h2 section ids are now generated by replacing space with hyphen "-" and converting to lower case.

Verification

  1. Execute npm run build
  2. View the generated HTML dist/plugins/index.html
  3. Search for <h2 id=" strings and confirm that ids are lower case and contain no whitespace.

Reference

@netlify
Copy link

netlify bot commented Jun 12, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ac41423

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 12, 2023 13:54
@nagash77 nagash77 requested a review from elylucas June 12, 2023 19:20
@elylucas elylucas merged commit da5d172 into cypress-io:main Jun 12, 2023
@MikeMcC399 MikeMcC399 deleted the fix/plugins-section-ids branch June 13, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants