Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update visual-testing.mdx anchor to point to #visual-testing #5354

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Update visual-testing.mdx anchor to point to #visual-testing #5354

merged 1 commit into from
Jul 5, 2023

Conversation

SimonGodefroid
Copy link
Contributor

@SimonGodefroid SimonGodefroid commented Jul 4, 2023 •
edited
Loading

The link was pointing to #Visual%20Testing

image

@netlify
Copy link

netlify bot commented Jul 4, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a91b896

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 mentioned this pull request Jul 4, 2023
Merged
@MikeMcC399
Copy link
Contributor

@SimonGodefroid

Many thanks for noticing and correcting this issue! It was caused by a previous PR #5299 I had submitted.

Will you sign the CLA? That is necessary for a PR to be processed.

I have submitted #5355 to fix the other related links.

@SimonGodefroid
Copy link
Contributor Author

@MikeMcC399 I've signed the CLA. Just let me know whether there's anything else I should do.

@MikeMcC399
Copy link
Contributor

@SimonGodefroid
Thanks! We just need the Cypress.io team to pick up the PR now.

@SimonGodefroid
Copy link
Contributor Author

SimonGodefroid commented Jul 5, 2023 •
edited
Loading

Just received this today in my tl;dr newsletter :D Seriously, don't sign a CLA

@jaffrepaul jaffrepaul merged commit 68ea93b into cypress-io:main Jul 5, 2023
@MikeMcC399 MikeMcC399 mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaffrepaul jaffrepaul jaffrepaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonGodefroid @CLAassistant @cypress-app-bot @MikeMcC399 @jaffrepaul