fix: don't pass invalid signal to subprocess.exit on crash (#15944)

cypress-io · Apr 12, 2021 · 86ffe20 · 86ffe20 · cypress-bot · Apr 12, 2021
1 parent 602c762
commit 86ffe20
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/server/lib/browsers/electron.js b/packages/server/lib/browsers/electron.js
@@ -431,8 +431,8 @@ module.exports = {
             return win.webContents.getOSProcessId()
           })],
           browserWindow: win,
-          kill: (isProcessExit) => {
-            if (isProcessExit) {
+          kill () {
+            if (this.isProcessExit) {
               // if the process is exiting, all BrowserWindows will be destroyed anyways
               return
             }

diff --git a/packages/server/lib/browsers/index.js b/packages/server/lib/browsers/index.js
@@ -36,7 +36,9 @@ const kill = function (unbind, isProcessExit) {
 
     debug('killing browser process')
 
-    _instance.kill(isProcessExit)
+    _instance.isProcessExit = isProcessExit
+
+    _instance.kill()
   })
 }