Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't pass invalid signal to subprocess.exit on crash #15944

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 12, 2021

User facing changelog

Fixed an issue where crashes in Cypress would cause a misleading "Unknown signal: true" error after the actual crash message.

Additional details

  • no users reported, but i have seen it a few times with random crashes

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig marked this pull request as ready for review April 12, 2021 17:04
@flotwig flotwig requested a review from a team as a code owner April 12, 2021 17:04
@flotwig flotwig requested review from JessicaSachs and removed request for a team April 12, 2021 17:04
@cypress
Copy link

cypress bot commented Apr 12, 2021



Test summary

9492 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 2fe5556
Started Apr 12, 2021 5:15 PM
Ended Apr 12, 2021 5:27 PM
Duration 12:09 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title fix: don't pass invalid signal to process.exit on crash fix: don't pass invalid signal to subprocess.exit on crash Apr 12, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Released in 7.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 12, 2021
@flotwig flotwig deleted the issue-15943 branch January 24, 2022 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress crashes with misleading error message "Unknown signal: true"
2 participants