Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Ensure we are publishing the correct versions of CT related npm packages for upcoming 10.0 release #21944

Closed
sync-by-unito bot opened this issue May 31, 2022 · 3 comments
Assignees
Labels
CT Issue related to component testing

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 31, 2022

Summary

With the upcoming 10.0-release, we need to ensure any CT related packages are published with a breaking change in conjunction with the release of 10.0 itself. Our documentation shows the use of custom functions that would require users to download the dev-servers as an npm dependency rather than relying on what is shipped in the binary so the publishing of these packages is mandatory.

We are releasing a new package called @cypress/vue2. This was previously released under the @cypress/vue@2 tag, but we split this package out.

Packages + versions:

  • @cypress/mount-utils: 2.0.0
  • @cypress/react: 6.0.0
  • @cypress/vue: 4.0.0
  • @cypress/vue2: 1.0.0 (New Package)
  • @cypress/webpack-dev-server: 2.0.0
  • @cypress/vite-dev-server: 3.0.0

Since we added a breaking change to @cypress/mount-utils, this necessitates a breaking change for all mount libraries.

To facilitate the breaking changes, we will need to push a commit to these packages with BREAKING CHANGE in the footer of the commit message for our semver to properly publish the new versions. Since we have new packages we are publishing and we did a drastic overhaul of the dev-servers, we should ensure that these packages are properly configured so as to facilitate their publish when we push a commit that enables their publishing.

Updates from Slack Convo:

Future considerations: Since we are bundling these packages in the binary, any breaking changes will result in a breaking change for Cypress. We should ensure that our current system for handling breaking changes works when we make breaking changes to the packages located in npm. Probably doesn't need to be figured out now but just wanted to note this.

There might not be too much work here, but it is important that we are ready and decided on what we are publishing and align it with the 10.0 release.

Slack thread with full convo:

https://cypressio.slack.com/archives/C01TQQCQLJY/p1652902314617969

Acceptance Criteria

  • Should publish breaking change for all CT related packages
  • Should NOT publish packages until 10.0 has been released
  • Ensure semantic-release is working correctly for all packages (changelogs etc…)

Resources

Any Notion documents, Google documents, Figma Boards

┆Issue is synchronized with this Jira Task by Unito
┆author: Zach Williams
┆epic: CT Architecture
┆friendlyId: UNIFY-1773
┆priority: Highest
┆sprint: Unification Release Sprint
┆taskType: Task

@sync-by-unito sync-by-unito bot added CT Issue related to component testing jira-migration labels May 31, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 31, 2022

➤ Zach Williams commented:

The changelog for @cypress/webpack-dev-server got removed so need to add that back in

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 31, 2022

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 31, 2022

➤ Chris Baus commented:

Ensure all dependencies are including in package.json prior to publish.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: open stage: needs review The PR code is done & tested, needs review labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing
Projects
None yet
Development

No branches or pull requests

3 participants