Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): support for Vue CLI 5 #20413

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Mar 1, 2022

User facing changelog

Support scaffolding a Vue CLI 5 project from launchpad.

Additional details

Vue CLI 5 is the latest version of a popular template and we should support it. We had support for V4, so this was easy to add.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 1, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 requested review from ZachJW34 and elylucas March 1, 2022 05:20
@lmiller1990 lmiller1990 changed the title Lmiller1990/unify 1220 vue cli 5 feat(launchpad): support for Vue CLI 5 Mar 1, 2022
@cypress
Copy link

cypress bot commented Mar 1, 2022



Test summary

17787 0 217 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 0a0f1b0
Started Mar 1, 2022 7:50 AM
Ended Mar 1, 2022 8:02 AM
Duration 12:00 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

net_stubbing.cy.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
xhr.cy.js Flakiness
1 ... > logs response

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lmiller1990 lmiller1990 merged commit e9125f4 into 10.0-release Mar 1, 2022
@lmiller1990 lmiller1990 deleted the lmiller1990/UNIFY-1220-vue-cli-5 branch March 1, 2022 22:04
tgriesser added a commit that referenced this pull request Mar 2, 2022
* 10.0-release:
  fix: comment link to accurate docs (#20437)
  fix: scaffold commands file (#20398)
  fix(launchpad): support default export (#20383)
  feat(launchpad): support for Vue CLI 5 (#20413)
  fix: UNIFY-676 browsers should be configurable in setupNodeEvents (#20367)
  fix: make launchpad link open default browser (#20399)
  fix(icons): publish the files in the package
  fix: build icons in build-prod (#20411)
  test: migrate module-api to 10.0
  chore: build this branch
  test: migrate module_api to system tests (#20265)
  chore: remove pkg/driver //@ts-nocheck final (#20169)
  chore: fix "cannot find module" in clone-repo-and-checkout-release-branch (#20293)
  chore: Update Chrome (beta) to 99.0.4844.45 (#20234)
  chore: fix CI cache state for darwin (#20339)
  Add TODO comments
  feedback
  chore: move tests to its own file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants