fix: remove asset size warnings and enable nuxt e2e tests #21074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
approved these changes
Apr 13, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
tgriesser
approved these changes
Apr 14, 2022
ryanthemanuel
approved these changes
Apr 14, 2022
tgriesser
added a commit
that referenced
this pull request
Apr 14, 2022
* 10.0-release: (25 commits) fix: stop running spec when switching specs (#21038) fix: remove asset size warnings and enable nuxt e2e tests (#21074) feat: swap the #__cy_root id selector to become data-cy-root for component mounting (#20951) fix: Doc changes around vue2 (#21066) feat: Add vue2 package from npm/vue/v2 branch (#21026) skip failing test fix: add possible frameworks to object API config (#21056) fix snapshot spacing fix system test fix snapshot update snapshots rename spec files rename files update snapshots release 9.5.4 [skip ci] fix(regression): cy.pause() should not be ignored with `cypress run --headed --no-exit` (#20877) fix: add missing Cypress.Commands.addAll() types (#20894) chore: Don't store video and screenshot artifacts for runs (#20979) chore: Update Chrome (beta) to 101.0.4951.26 (#20957) chore: remove parallelism from test-binary-against-repo jobs (#21004) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Remove asset size warnings from nuxt webpack-dev-server
Additional details
The default nuxt webpack config has
webpack.performanceconfigured which causes an overlay in the browser if a bundle is too large. This is unnecessary for development/testing purposes so theperformanceobject is now removed from the webpack configuration.I enabled the tests for nuxt now that
cypress/vue2has been merged. Had to add a webpack alias to the system test to get around a module resolution issue that is specific to system-tests. The system-tests for nuxt are slower than the rest as it takes longer for webpack to recompile the files so I bumped thedefaultCommandTimeout.How has the user experience changed?
Two tests, first showing the unwanted overlay and second after the removal.
Screen.Recording.2022-04-13.at.4.08.30.PM.mov
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?