Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert submit validation #15302

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

chrisbreiding
Copy link
Contributor

Reverts #14965 and #15266.

Sorry @sainthkh, I merged the submit validation PR prematurely before we discussed it as a team. In case we decide it's not the desired behavior, we'd rather not implement it for the time being, because reverting it would be another breaking change. We're erring on the side of keeping it out of this release until we can prioritize and fully discuss how we'd like to handle this.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 3, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the title Revert submit validation chore: Revert submit validation Mar 3, 2021
@cypress
Copy link

cypress bot commented Mar 3, 2021



Test summary

9374 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 89a7ec6
Started Mar 3, 2021 3:12 PM
Ended Mar 3, 2021 3:23 PM
Duration 10:56 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane mentioned this pull request Mar 3, 2021
15 tasks
@chrisbreiding chrisbreiding merged commit fb593be into 7.0-release Mar 3, 2021
@sainthkh
Copy link
Contributor

sainthkh commented Mar 3, 2021

OK, I also didn't check it solves all the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants