Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: res.send of cy.intercept doesn't override json-related content types #17401

Merged
merged 6 commits into from
Aug 6, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jul 19, 2021

Reverts #17400

Re-adds #17199

Closes #17084

User facing changelog

res.send of cy.intercept doesn't override json-related content types.

…de json-related content types. " (#17400)"

This reverts commit 190294c.
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 19, 2021

Thanks for taking the time to open a PR!

Copy link
Contributor Author

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sainthkh this was causing a CI failure in develop that looks legitimate, can you please take a look at the review comments on this PR and resolve them?

@cypress
Copy link

cypress bot commented Jul 19, 2021



Test summary

8359 0 103 3Flakiness 4


Run details

Project cypress
Status Passed
Commit dd7c3af
Started Aug 6, 2021 12:24 AM
Ended Aug 6, 2021 12:35 AM
Duration 10:22 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing
commands/xhr_spec.js Flakiness
1 src/cy/commands/xhr > abort > aborts xhrs currently in flight
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps
2 Proxy Logging > request logging > fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding marked this pull request as ready for review July 29, 2021 14:42
@chrisbreiding chrisbreiding requested a review from a team as a code owner July 29, 2021 14:42
@chrisbreiding chrisbreiding requested review from jennifer-shehane and kuceb and removed request for a team July 29, 2021 14:42
@flotwig flotwig merged commit a92b0c1 into develop Aug 6, 2021
@flotwig flotwig deleted the revert-17400-revert-17199-issue-17084 branch January 24, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intercept resets compatible content type when body is an object
2 participants