fix: cy.contains() ignores <style> and <script> without removing them.
#19424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
I pulled this change down locally & verifying the changes agains the cypress-contains-script repo provided to demonstrate the issue. This change appears to resolve ##19377 while maintain the intended fix for #14861. |
chrisbreiding
previously approved these changes
Dec 20, 2021
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
chrisbreiding
previously approved these changes
Dec 20, 2021
emilyrohrbough
previously approved these changes
Dec 20, 2021
mjhenkes
requested review from
jennifer-shehane
and removed request for
a team
mjhenkes
reviewed
Dec 20, 2021
mjhenkes
dismissed stale reviews from emilyrohrbough and chrisbreiding
via
25c0d54
chrisbreiding
approved these changes
Dec 20, 2021
emilyrohrbough
approved these changes
Dec 20, 2021
|
Thank you @sainthkh for the quick fix! |
tgriesser
added a commit
that referenced
this pull request
Dec 21, 2021
…ert-with-stack * tgriesser/10.0-release/refactor-lifecycle: (50 commits) Remove unused test file update task spec to use correct projectRoot update Fix test Fix test Fix tests update tests fix test correct config path Fix TS resolve conflicts Fixing component & e2e tests build: fix dev process on windows (#19401) fix: `cy.contains()` ignores `<style>` and `<script>` without removing them. (#19424) Fix some tests chore: Fix the broken codeowners automation (#19431) chore: add types for Cypress.session.clearAllSavedSessions (#19412) fix: No unnecessary snapshotting (#19311) chore: Remove pkg/driver @ts-nocheck part 1 (#19353) fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it (#19282) ...
|
Thanks @sainthkh and Cypress team for the quick response, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cy.containsremoves<script>and<style>nodes from the app under test #19377User facing changelog
cy.contains()ignores<style>and<script>without removing them.Additional details
cy.contains()removed<style>and<script>to ignore them. But it causes many unexpected errors.How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?