Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small ui tweaks for switch testing type #20901

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Apr 4, 2022

User facing changelog

NA

Additional details

Small tweaks tot he "Switch Testing Type" button, centering the icon and animating the icon in the direction the icon is pointing.

How has the user experience changed?

Before:

Screen.Recording.2022-04-04.at.4.48.07.PM.mov

After:

Screen.Recording.2022-04-04.at.4.44.48.PM.mov

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested a review from marktnoonan April 4, 2022 21:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 4, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 4, 2022



Test summary

17812 0 217 0Flakiness 1


Run details

Project cypress
Status Passed
Commit e0cab10
Started Apr 5, 2022 8:53 PM
Ended Apr 5, 2022 9:05 PM
Duration 12:01 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 src/cy/commands/xhr > #startXhrServer > calls onload handlers attached after xhr#send asynchronously

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 merged commit edf5595 into 10.0-release Apr 5, 2022
@ZachJW34 ZachJW34 deleted the zachw/small-browserlist-ui-fix branch April 5, 2022 21:12
lmiller1990 added a commit that referenced this pull request Apr 13, 2022
* fix: small ui tweaks for switch testing type (#20901)

* fix: add missing component-index.html (#20926)

* move files from data-context to scaffold-config

* dynamically modify support file based on selected framework

* scaffold correct supportFile for CT based on framework

* update scaffolded files

Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants