Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing component-index.html #20926

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Apr 5, 2022

User facing changelog

NA

Additional details

Adding a missing file that was causing some the dev-server for certain tests to throw errors. No tests are failing, but good to cleanup the logs and have the system tests structured as they should be.

How has the user experience changed?

No longer see

ERROR in Entry module not found: Error: Can't resolve '/private/var/folders/8q/b_sy2fp93fs5k7mvkxn60g4r0000gn/T/cy-projects/component-tests/cypress/support/component-index.html' in '/private/var/folders/8q/b_sy2fp93fs5k7mvkxn60g4r0000gn/T/cy-projects/component-tests'

when running system tests that point to the component-tests project.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@ZachJW34 ZachJW34 requested a review from marktnoonan April 5, 2022 21:02
@ZachJW34 ZachJW34 requested review from a team as code owners April 5, 2022 21:02
@ZachJW34 ZachJW34 requested review from jennifer-shehane and removed request for a team April 5, 2022 21:02
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 5, 2022



Test summary

17812 0 217 0Flakiness 0


Run details

Project cypress
Status Passed
Commit ddfdfed
Started Apr 5, 2022 9:20 PM
Ended Apr 5, 2022 9:32 PM
Duration 12:15 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane removed their request for review April 5, 2022 21:32
@lmiller1990 lmiller1990 merged commit 1d2d6a4 into 10.0-release Apr 5, 2022
@lmiller1990 lmiller1990 deleted the zachw/add-missing-component-html branch April 5, 2022 23:01
lmiller1990 added a commit that referenced this pull request Apr 13, 2022
* fix: small ui tweaks for switch testing type (#20901)

* fix: add missing component-index.html (#20926)

* move files from data-context to scaffold-config

* dynamically modify support file based on selected framework

* scaffold correct supportFile for CT based on framework

* update scaffolded files

Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants