-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support loading config files for projects with type module, without esbuild #21574
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
53d500c
fix: support loading config files for projects with type module, with…
JessicaSachs a18bb9e
Update packages/server/lib/plugins/child/run_require_async_child.js
JessicaSachs 5733d7c
Update packages/server/lib/plugins/child/run_require_async_child.js
JessicaSachs 2d4399e
Merge branch '10.0-release' into fix/module-projects-without-esbuild
JessicaSachs 3d06929
Merge branch '10.0-release' into fix/module-projects-without-esbuild
JessicaSachs 63b428a
fix: adding process.cwd() to require.resolve paths so that system-tes…
JessicaSachs d007fd6
Merge branch '10.0-release' into fix/module-projects-without-esbuild
tgriesser a7c71dd
Merge branch 'develop' of github.com:cypress-io/cypress into fix/modu…
JessicaSachs 7c5350a
fix: missing esbuild from test
JessicaSachs d5ba8cc
Merge branch 'fix/module-projects-without-esbuild' of github.com:cypr…
JessicaSachs 89d2077
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs 7ed4ba7
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs e77a696
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs 582e2c4
test
JessicaSachs 69e530a
Merge remote-tracking branch 'origin' into fix/module-projects-withou…
JessicaSachs d35c9ed
Merge branch 'fix/module-projects-without-esbuild' of github.com:cypr…
JessicaSachs 26e1378
build plz
flotwig d437afd
Merge branch 'develop' into fix/module-projects-without-esbuild
tgriesser facb21c
Merge branch 'develop' into fix/module-projects-without-esbuild
mjhenkes c952a29
Update test case to capture failure
tgriesser d2d8d15
Merge branch 'develop' into fix/module-projects-without-esbuild
mjhenkes 310a44e
empty message for fresh CI
tgriesser 08a87d8
fix flaky test
tgriesser 71cbb69
See if esbuild helps with migration-e2e-module on windows
tgriesser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
system-tests/projects/config-with-ts-module-error/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "dependencies": { | ||
| "find-up": "6.3.0" | ||
| "find-up": "6.3.0", | ||
| "esbuild": "0.14.39" | ||
| }, | ||
| "type": "module" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| { | ||
| "devDependencies": { | ||
| "esbuild": "0.14.25" | ||
| }, | ||
| "type": "module" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | ||
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| esbuild-android-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-android-64/-/esbuild-android-64-0.14.25.tgz#d532d38cb5fe0ae45167ce35f4bbc784c636be40" | ||
| integrity sha512-L5vCUk7TzFbBnoESNoXjU3x9+/+7TDIE/1mTfy/erAfvZAqC+S3sp/Qa9wkypFMcFvN9FzvESkTlpeQDolREtQ== | ||
|
|
||
| esbuild-android-arm64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-android-arm64/-/esbuild-android-arm64-0.14.25.tgz#9c5bb3366aabfd14a1c726d36978b79441dfcb6e" | ||
| integrity sha512-4jv5xPjM/qNm27T5j3ZEck0PvjgQtoMHnz4FzwF5zNP56PvY2CT0WStcAIl6jNlsuDdN63rk2HRBIsO6xFbcFw== | ||
|
|
||
| esbuild-darwin-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-darwin-64/-/esbuild-darwin-64-0.14.25.tgz#05dcdb6d884f427039ffee5e92ff97527e56c26d" | ||
| integrity sha512-TGp8tuudIxOyWd1+8aYPxQmC1ZQyvij/AfNBa35RubixD0zJ1vkKHVAzo0Zao1zcG6pNqiSyzfPto8vmg0s7oA== | ||
|
|
||
| esbuild-darwin-arm64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-darwin-arm64/-/esbuild-darwin-arm64-0.14.25.tgz#28e080da4ea0cfe9498071e7f8060498caee1a95" | ||
| integrity sha512-oTcDgdm0MDVEmw2DWu8BV68pYuImpFgvWREPErBZmNA4MYKGuBRaCiJqq6jZmBR1x+3y1DWCjez+5uLtuAm6mw== | ||
|
|
||
| esbuild-freebsd-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-freebsd-64/-/esbuild-freebsd-64-0.14.25.tgz#200d3664a3b945bc9fdcba73614b49a11ebd1cfa" | ||
| integrity sha512-ueAqbnMZ8arnuLH8tHwTCQYeptnHOUV7vA6px6j4zjjQwDx7TdP7kACPf3TLZLdJQ3CAD1XCvQ2sPhX+8tacvQ== | ||
|
|
||
| esbuild-freebsd-arm64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-freebsd-arm64/-/esbuild-freebsd-arm64-0.14.25.tgz#624b08c5da6013bdc312aaa23c4ff409580f5c3c" | ||
| integrity sha512-+ZVWud2HKh+Ob6k/qiJWjBtUg4KmJGGmbvEXXW1SNKS7hW7HU+Zq2ZCcE1akFxOPkVB+EhOty/sSek30tkCYug== | ||
|
|
||
| esbuild-linux-32@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-32/-/esbuild-linux-32-0.14.25.tgz#0238e597eb0b60aa06c7e98fccbbfd6bb9a0d6c5" | ||
| integrity sha512-3OP/lwV3kCzEz45tobH9nj+uE4ubhGsfx+tn0L26WAGtUbmmcRpqy7XRG/qK7h1mClZ+eguIANcQntYMdYklfw== | ||
|
|
||
| esbuild-linux-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-64/-/esbuild-linux-64-0.14.25.tgz#8a8b8cf47dfce127c858e71229d9a385a82c62e8" | ||
| integrity sha512-+aKHdHZmX9qwVlQmu5xYXh7GsBFf4TWrePgeJTalhXHOG7NNuUwoHmketGiZEoNsWyyqwH9rE5BC+iwcLY30Ug== | ||
|
|
||
| esbuild-linux-arm64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-arm64/-/esbuild-linux-arm64-0.14.25.tgz#7ac94371418a2640ba413bc1700aaedeb2794e52" | ||
| integrity sha512-UxfenPx/wSZx55gScCImPtXekvZQLI2GW3qe5dtlmU7luiqhp5GWPzGeQEbD3yN3xg/pHc671m5bma5Ns7lBHw== | ||
|
|
||
| esbuild-linux-arm@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-arm/-/esbuild-linux-arm-0.14.25.tgz#034bd18e9310b9f010c89f90ef7f05706689600b" | ||
| integrity sha512-aTLcE2VBoLydL943REcAcgnDi3bHtmULSXWLbjtBdtykRatJVSxKMjK9YlBXUZC4/YcNQfH7AxwVeQr9fNxPhw== | ||
|
|
||
| esbuild-linux-mips64le@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-mips64le/-/esbuild-linux-mips64le-0.14.25.tgz#05f98a8cf6b578eab6b4e6b0ab094f37530934f4" | ||
| integrity sha512-wLWYyqVfYx9Ur6eU5RT92yJVsaBGi5RdkoWqRHOqcJ38Kn60QMlcghsKeWfe9jcYut8LangYZ98xO1LxIoSXrQ== | ||
|
|
||
| esbuild-linux-ppc64le@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-ppc64le/-/esbuild-linux-ppc64le-0.14.25.tgz#46fd0add8d8535678439d7a9c2876ad20042d952" | ||
| integrity sha512-0dR6Csl6Zas3g4p9ULckEl8Mo8IInJh33VCJ3eaV1hj9+MHGdmDOakYMN8MZP9/5nl+NU/0ygpd14cWgy8uqRw== | ||
|
|
||
| esbuild-linux-riscv64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-riscv64/-/esbuild-linux-riscv64-0.14.25.tgz#ea2e986f0f3e5df73c635135dd778051734fc605" | ||
| integrity sha512-J4d20HDmTrgvhR0bdkDhvvJGaikH3LzXQnNaseo8rcw9Yqby9A90gKUmWpfwqLVNRILvNnAmKLfBjCKU9ajg8w== | ||
|
|
||
| esbuild-linux-s390x@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-linux-s390x/-/esbuild-linux-s390x-0.14.25.tgz#efe89486e9a1b1508925048076e3f3a6698aa6a3" | ||
| integrity sha512-YI2d5V6nTE73ZnhEKQD7MtsPs1EtUZJ3obS21oxQxGbbRw1G+PtJKjNyur+3t6nzHP9oTg6GHQ3S3hOLLmbDIQ== | ||
|
|
||
| esbuild-netbsd-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-netbsd-64/-/esbuild-netbsd-64-0.14.25.tgz#439fe27d8ee3b5887501ee63988e85f920107db6" | ||
| integrity sha512-TKIVgNWLUOkr+Exrye70XTEE1lJjdQXdM4tAXRzfHE9iBA7LXWcNtVIuSnphTqpanPzTDFarF0yqq4kpbC6miA== | ||
|
|
||
| esbuild-openbsd-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-openbsd-64/-/esbuild-openbsd-64-0.14.25.tgz#31ebf616aadf6e60674469f2b92cec92280d9930" | ||
| integrity sha512-QgFJ37A15D7NIXBTYEqz29+uw3nNBOIyog+3kFidANn6kjw0GHZ0lEYQn+cwjyzu94WobR+fes7cTl/ZYlHb1A== | ||
|
|
||
| esbuild-sunos-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-sunos-64/-/esbuild-sunos-64-0.14.25.tgz#815e4f936d74970292a63ccfd5791fe5e3569f5f" | ||
| integrity sha512-rmWfjUItYIVlqr5EnTH1+GCxXiBOC42WBZ3w++qh7n2cS9Xo0lO5pGSG2N+huOU2fX5L+6YUuJ78/vOYvefeFw== | ||
|
|
||
| esbuild-windows-32@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-windows-32/-/esbuild-windows-32-0.14.25.tgz#189e14df2478f2c193c86968ab1fb54e1ceaafd2" | ||
| integrity sha512-HGAxVUofl3iUIz9W10Y9XKtD0bNsK9fBXv1D55N/ljNvkrAYcGB8YCm0v7DjlwtyS6ws3dkdQyXadbxkbzaKOA== | ||
|
|
||
| esbuild-windows-64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-windows-64/-/esbuild-windows-64-0.14.25.tgz#3d5fbfdc3856850bb47439299e3b60dd18be111f" | ||
| integrity sha512-TirEohRkfWU9hXLgoDxzhMQD1g8I2mOqvdQF2RS9E/wbkORTAqJHyh7wqGRCQAwNzdNXdg3JAyhQ9/177AadWA== | ||
|
|
||
| esbuild-windows-arm64@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild-windows-arm64/-/esbuild-windows-arm64-0.14.25.tgz#8b243cbbad8a86cf98697da9ccb88c05df2ef458" | ||
| integrity sha512-4ype9ERiI45rSh+R8qUoBtaj6kJvUOI7oVLhKqPEpcF4Pa5PpT3hm/mXAyotJHREkHpM87PAJcA442mLnbtlNA== | ||
|
|
||
| esbuild@0.14.25: | ||
| version "0.14.25" | ||
| resolved "https://registry.yarnpkg.com/esbuild/-/esbuild-0.14.25.tgz#ddb9d47b91ca76abb7d850ce3dfed0bc3dc88d16" | ||
| integrity sha512-4JHEIOMNFvK09ziiL+iVmldIhLbn49V4NAVo888tcGFKedEZY/Y8YapfStJ6zSE23tzYPKxqKwQBnQoIO0BI/Q== | ||
| optionalDependencies: | ||
| esbuild-android-64 "0.14.25" | ||
| esbuild-android-arm64 "0.14.25" | ||
| esbuild-darwin-64 "0.14.25" | ||
| esbuild-darwin-arm64 "0.14.25" | ||
| esbuild-freebsd-64 "0.14.25" | ||
| esbuild-freebsd-arm64 "0.14.25" | ||
| esbuild-linux-32 "0.14.25" | ||
| esbuild-linux-64 "0.14.25" | ||
| esbuild-linux-arm "0.14.25" | ||
| esbuild-linux-arm64 "0.14.25" | ||
| esbuild-linux-mips64le "0.14.25" | ||
| esbuild-linux-ppc64le "0.14.25" | ||
| esbuild-linux-riscv64 "0.14.25" | ||
| esbuild-linux-s390x "0.14.25" | ||
| esbuild-netbsd-64 "0.14.25" | ||
| esbuild-openbsd-64 "0.14.25" | ||
| esbuild-sunos-64 "0.14.25" | ||
| esbuild-windows-32 "0.14.25" | ||
| esbuild-windows-64 "0.14.25" | ||
| esbuild-windows-arm64 "0.14.25" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The absence of this line was actually a bug and it was only working on my machine because of some GLOBAL transitive deps with
esbuild.To debug this, you can add
to a production-built binary installed in a real project. We should really consider moving some of these low-dependency or no-dependency tests OUTSIDE of the system-tests and into the
binary-system-testsphase.