fix: support loading config files for projects with type module, without esbuild #21574
Conversation
JessicaSachs
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
…ts do not use local dev version of esbuild
|
There was a test already written, but it wasn't failing correctly due to differences between prod and test. When running system-tests, was designed to cover. By adding |
| @@ -111,14 +111,14 @@ function run (ipc, file, projectRoot) { | |||
| try { | |||
| debug('Trying to use esbuild to run their config file.') | |||
| // We prefer doing this because it supports TypeScript files | |||
| require.resolve('esbuild') | |||
| require.resolve('esbuild', { paths: [process.cwd()] }) | |||
There was a problem hiding this comment.
The absence of this line was actually a bug and it was only working on my machine because of some GLOBAL transitive deps with esbuild.
To debug this, you can add
require.resolve.paths('esbuild')to a production-built binary installed in a real project. We should really consider moving some of these low-dependency or no-dependency tests OUTSIDE of the system-tests and into the binary-system-tests phase.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
There was a problem hiding this comment.
@JessicaSachs Update the base branch to be against develop before merging.
…le-projects-without-esbuild
…ess-io/cypress into fix/module-projects-without-esbuild
…ess-io/cypress into fix/module-projects-without-esbuild
@flotwig or @lmiller1990 I could use a hand in figuring out why the existing test suite here does not fail.
Do we always have
esbuildin the require callstack? I thought we sandboxed the node_modules well enough in the temp dir.User facing changelog
We now support Cypress Config files for project that have
"type": "module"in their package.json, but do not have a dependency onesbuild.