WIP Native Events #2436
Closed
WIP Native Events #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,6 +186,7 @@ ensureElIsNotCovered = (cy, win, $el, fromViewport, options, log, onScroll) -> | |||
| return $elAtCoords | |||
|
|
|||
| getCoordinatesForEl = (cy, $el, options) -> | |||
| debugger | |||
There was a problem hiding this comment.
Y'all need some linters running on precommit hooks, debugger should never been committed. 👀
There was a problem hiding this comment.
its a WIP, so i use --no-verify
There was a problem hiding this comment.
I don't think we should bother reviewing WIP PR's, isn't that the point of WIP? 😄
There was a problem hiding this comment.
Agree with @bkucera if we indicate a WIP on a PR it should be ignored and not be reviewed.
Merged
decaffeinate: Rename keyboard.coffee from .coffee to .js decaffeinate: Rename click.coffee from .coffee to .js decaffeinate: Rename type.coffee from .coffee to .js
decaffeinate: Convert type.coffee to JS decaffeinate: Run post-processing cleanups on type.coffee decaffeinate: Convert keyboard.coffee to JS decaffeinate: Run post-processing cleanups on keyboard.coffee decaffeinate: Convert click.coffee to JS decaffeinate: Run post-processing cleanups on click.coffee
|
@bkucera any objections to closing this one? |
|
closing since this is very stale and no longer a blocker for cross-browser support (which is released) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #311
typing into datetime-local input type
fix Cannot type on datetime-local input #2613
input events for
{enter}:fix type('{enter}') doesn't fire input event #3405
sending
codeproperty on keyboard eventfix cy.type doesn't fill in KeyboardEvent.code #3722
follow w3 spec for number inputs
fix cannot
typenegative number into number input with text selection #4767Tasks