WIP Native Events

.eslintignore

@@ -1,6 +1,19 @@
-__snapshots__
+**/__snapshots__
+**/build
+**/cypress/fixtures
+**/dist
+**/dist-test
+**/node_modules
+**/support/fixtures
+**/test/fixtures
+**/vendor
+
+# cli/types is linted by tslint/dtslint
+cli/types
+# packages/example is not linted (think about changing this)
+packages/example
+
+packages/extension/test/helpers/background.js
 packages/server/lib/scaffold/plugins/index.js
 packages/server/lib/scaffold/support/index.js
 packages/server/lib/scaffold/support/commands.js
-packages/server/test/fixtures
-packages/example/cypress

.eslintrc

@@ -1,71 +1,69 @@
 {
+  "parser": "@typescript-eslint/parser",
+  "plugins": [
+    "@typescript-eslint"
+  ],
   "extends": [
     "plugin:cypress-dev/general"
   ],
   "rules": {
-    "no-multiple-empty-lines": ["error", { "max": 1 } ],
-    "no-else-return": [ "error", { "allowElseIf": false } ],
-    "brace-style": ["error", "1tbs", { "allowSingleLine": false }],
-    "no-unneeded-ternary": ["error"],
-    "array-bracket-newline": ["error", "consistent"],
-    "arrow-body-style": ["error", "always"],
-    "padding-line-between-statements": [
+    "brace-style": [
       "error",
+      "1tbs",
       {
-        "blankLine": "always",
-        "prev": "*",
-        "next": "return"
-      },
-      {
-        "blankLine": "always",
-        "prev": [
-          "const",
-          "let",
-          "var",
-          "if",
-          "while",
-          "export",
-          "cjs-export",
-          "import",
-          "cjs-import"
-        ],
-        "next": "*"
-      },
+        "allowSingleLine": false
+      }
+    ],
+    "no-multiple-empty-lines": [
+      "error",
       {
-        "blankLine": "any",
-        "prev": [
-          "const",
-          "let",
-          "var",
-          "import",
-          "cjs-import"
-        ],
-        "next": [
-          "const",
-          "let",
-          "var",
-          "import",
-          "cjs-import"
-        ]
+        "max": 1
       }
+    ],
+    "function-paren-newline": [
+      "error",
+      "consistent"
     ]
   },
   "env": {
     "es6": true,
     "node": true
   },
   "parserOptions": {
+    "ecmaVersion": 2018,
+    "sourceType": "module",
     "ecmaFeatures": {
       "legacyDecorators": true
     }
   },
   "overrides": [
     {
       "files": [
-        "**/*.jsx"
+        "*.ts"
       ],
       "rules": {
-        "arrow-body-style": "off"
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": "error",
+        "no-useless-constructor": "off",
+        "@typescript-eslint/no-useless-constructor": [
+          "error"
+        ],
+        "semi": "off",
+        "@typescript-eslint/semi": [
+          "error",
+          "never"
+        ],
+        "@typescript-eslint/member-delimiter-style": [
+          "error",
+          {
+            "multiline": {
+              "delimiter": "none"
+            },
+            "singleline": {
+              "delimiter": "comma"
+            }
+          }
+        ]
       }
     }
   ]

.prettierignore

@@ -1 +1,2 @@
 **/*
+

CONTRIBUTING.md

@@ -362,7 +362,7 @@ When you edit files, you can quickly fix all changed files before committing usi
 npm run lint-changed
 ```
 
-When committing files, we run Git pre-commit hook to fix the staged JS files. See the `precommit-lint` script in [package.json](package.json). This might change JS files and you would need to commit the changes again.
+When committing files, we run Git pre-commit hook to fix the staged and unstaged JS files. See the `precommit-lint` script in [package.json](package.json). This might change JS files and you would need to commit the changes again.
 
 ### Tests
 

__snapshots__/packages-spec.js

@@ -0,0 +1,112 @@
+exports['packages can copy files from package.json 1'] = {
+  "[cwd]": {
+    "packages": {
+      "coffee": {
+        "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+        "src": {
+          "main.js": "console.log()"
+        },
+        "lib": {
+          "foo.js": "{}"
+        }
+      }
+    }
+  },
+  "tmp": {
+    "packages": {
+      "coffee": {
+        "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+        "src": {
+          "main.js": "console.log()"
+        },
+        "lib": {
+          "foo.js": "{}"
+        }
+      }
+    }
+  }
+}
+
+exports['transformRequires can find and replace symlink requires 1'] = {
+  "[cwd]": {
+    "build": {
+      "linux": {
+        "Cypress": {
+          "resources": {
+            "app": {
+              "packages": {
+                "foo": {
+                  "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+                  "src": {
+                    "main.js": "console.log()"
+                  },
+                  "lib": {
+                    "foo.js": "require(\"../../bar/src/main\")"
+                  }
+                },
+                "bar": {
+                  "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+                  "src": {
+                    "main.js": "console.log()"
+                  },
+                  "lib": {
+                    "foo.js": "require(\"../../foo/lib/somefoo\")"
+                  },
+                  "node_modules": {
+                    "no-search.js": ""
+                  },
+                  "dist": {
+                    "no-search.js": ""
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  },
+  "tmp": {}
+}
+
+exports['transformRequires can find and replace symlink requires on win32 1'] = {
+  "[cwd]": {
+    "build": {
+      "linux": {
+        "Cypress": {
+          "resources": {
+            "app": {
+              "packages": {
+                "foo": {
+                  "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+                  "src": {
+                    "main.js": "console.log()"
+                  },
+                  "lib": {
+                    "foo.js": "require(\"../../bar/src/main\")"
+                  }
+                },
+                "bar": {
+                  "package.json": "{\"main\":\"src/main.js\", \"name\": \"foo\", \"files\": [\"lib\"]}",
+                  "src": {
+                    "main.js": "console.log()"
+                  },
+                  "lib": {
+                    "foo.js": "require(\"../../foo/lib/somefoo\")"
+                  },
+                  "node_modules": {
+                    "no-search.js": ""
+                  },
+                  "dist": {
+                    "no-search.js": ""
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  },
+  "tmp": {}
+}

circle.yml

@@ -206,7 +206,6 @@ jobs:
       - attach_workspace:
           at: ~/
       - run: npm run lint
-      - run: npm run all lint
 
   unit-tests:
     <<: *defaults
@@ -237,7 +236,7 @@ jobs:
       - store_test_results:
           path: /tmp/cypress
 
-  lint-typescript:
+  lint-types:
     <<: *defaults
     parallelism: 1
     steps:
@@ -723,7 +722,7 @@ linux-workflow: &linux-workflow
         name: Linux lint
         requires:
           - build
-    - lint-typescript:
+    - lint-types:
         requires:
           - build
     # unit, integration and e2e tests

cli/lib/cli.js

@@ -40,6 +40,7 @@ const spaceDelimitedSpecsMsg = (files) => {
     If you are trying to pass multiple spec filenames, separate them by commas instead:
       cypress run --spec spec1,spec2,spec3
   `)
+
   logger.log()
 }
 
@@ -73,8 +74,7 @@ const parseOpts = (opts) => {
     'project', 'spec', 'reporter', 'reporterOptions', 'path', 'destination',
     'port', 'env', 'cypressVersion', 'config', 'record', 'key',
     'browser', 'detached', 'headed', 'global', 'dev', 'force', 'exit',
-    'cachePath', 'cacheList', 'cacheClear', 'parallel', 'group', 'ciBuildId'
-  )
+    'cachePath', 'cacheList', 'cacheClear', 'parallel', 'group', 'ciBuildId')
 
   if (opts.exit) {
     opts = _.omit(opts, 'exit')

cli/lib/tasks/download.js

@@ -111,7 +111,8 @@ const verifyDownloadedFile = (filename, expectedSize, expectedChecksum) => {
         debug(text)
 
         throw new Error(text)
-      })
+      }
+    )
   }
 
   if (expectedChecksum) {
@@ -211,6 +212,7 @@ const downloadFromUrl = ({ url, downloadDestination, progress }) => {
       // see https://github.com/cypress-io/cypress/pull/4092
       expectedSize = response.headers['x-amz-meta-size'] ||
         response.headers['content-length']
+
       expectedChecksum = response.headers['x-amz-meta-checksum']
 
       if (expectedChecksum) {
@@ -274,9 +276,11 @@ const downloadFromUrl = ({ url, downloadDestination, progress }) => {
  * @param [string] version Could be "3.3.0" or full URL
  * @param [string] downloadDestination Local filename to save as
  */
-const start = ({ version, downloadDestination, progress }) => {
+const start = (opts) => {
+  let { version, downloadDestination, progress } = opts
+
   if (!downloadDestination) {
-    la(is.unemptyString(downloadDestination), 'missing download dir', arguments)
+    la(is.unemptyString(downloadDestination), 'missing download dir', opts)
   }
 
   if (!progress) {

cli/lib/tasks/install.js

@@ -164,7 +164,9 @@ const start = (options = {}) => {
       debug('environment variable CYPRESS_INSTALL_BINARY = 0, skipping install')
       logger.log(
         stripIndent`
-        ${chalk.yellow('Note:')} Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.`)
+        ${chalk.yellow('Note:')} Skipping binary installation: Environment variable CYPRESS_INSTALL_BINARY = 0.`
+      )
+
       logger.log()
 
       return Promise.resolve()
@@ -187,7 +189,9 @@ const start = (options = {}) => {
         ${chalk.yellow('Note:')} Overriding Cypress cache directory to: ${chalk.cyan(envCache)}
 
               Previous installs of Cypress may not be found.
-      `)
+      `
+    )
+
     logger.log()
   }
 
@@ -220,6 +224,7 @@ const start = (options = {}) => {
     logger.log(stripIndent`
       Cypress ${chalk.green(binaryVersion)} is installed in ${chalk.cyan(installDir)}
       `)
+
     logger.log()
 
     if (options.force) {
@@ -257,6 +262,7 @@ const start = (options = {}) => {
             These versions may not work properly together.
         `)
       )
+
       logger.log()
     }
 

cli/lib/tasks/state.js

@@ -118,7 +118,8 @@ const writeBinaryVerifiedAsync = (verified, binaryDir) => {
     return fs.outputJsonAsync(
       getBinaryStatePath(binaryDir),
       _.extend(contents, { verified }),
-      { spaces: 2 })
+      { spaces: 2 }
+    )
   })
 }
 

cli/lib/tasks/verify.js

@@ -260,6 +260,7 @@ const start = (options = {}) => {
 
       This overrides the default Cypress binary path used.
     `)
+
     logger.log()
 
     return util.isExecutableAsync(envBinaryPath)