misc: style change for responsiveness #25687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #43796 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
ZachJW34
approved these changes
Feb 2, 2023
lmiller1990
approved these changes
Feb 3, 2023
|
@warrensplayer it has to do with the separator, mostly - the vertical space between each list item is 8px, but each one is a different size internally. I really enjoy making stuff like this perfect, but didn't think it was worth spending time on it in this case that's so hard to hit in the app. |
mike-plummer
approved these changes
Feb 3, 2023
cli/CHANGELOG.md
Outdated
|
|
||
| **Misc:** | ||
|
|
||
| - Improved the responsiveness of the Debug Page pending run UI. Addresses [#25664](https://github.com/cypress-io/cypress/issues/25664). |
There was a problem hiding this comment.
Wordsmithing nitpick: "Improved the layout of the Debug Page on smaller viewports when there is a pending run."
Maybe it's just me, but I interpret the phrase "improved responsiveness" as "performance improvement"
marktnoonan
commented
Feb 4, 2023
tgriesser
added a commit
that referenced
this pull request
Feb 8, 2023
* develop: (28 commits) chore: update changelog validation example (#25742) fix: Improve error handling around calls to `this.next` in middleware (#25702) chore: debug page tooltip distance and artifact border (#25727) fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730) misc: Add max widths to debug page message states (#25725) chore: export types (#25714) chore: release @cypress/webpack-preprocessor-v5.16.3 chore: release @cypress/vue-v5.0.4 chore: release @cypress/grep-v3.1.4 chore: Fix flaky test (#25726) dependency(deps): update dependency debug to ^4.3.4 🌟 (#25699) feat: openInIDE for failed debug spec (#25691) test: fix flaky CT test by relying on query (#25706) test: fix flaky migration test (#25672) misc: style change for responsiveness (#25687) misc: set min widths for icons (#25684) chore(deps): update dependency markdown-it to v11.0.1 🌟 (#25698) chore: Fix flaky origin .wait() test (#25693) chore: unskip tests (#25676) chore: release @cypress/webpack-preprocessor-v5.16.2 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This modifies some CSS to get a better experience in cases where the content of this component is wider than a single row.
Steps to test
Mainly I would look at the percy snapshots. The situations where this can wrap in the app are pretty rare and would involve long commit messages or high zoom levels since the debug page has a minimum width.
To test this in the live app, you can open Cypress to the Debug page when a run is in progress and modify the DOM of the "next run" display to include unusually long text.
How has the user experience changed?
Old on left, new on right:
PR Tasks
cypress-documentation?type definitions?