Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: openInIDE for failed debug spec #25691

Merged
merged 7 commits into from
Feb 6, 2023
Merged

feat: openInIDE for failed debug spec #25691

merged 7 commits into from
Feb 6, 2023

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Feb 2, 2023

Additional details

Reuse the OpenFileInIDE component to launch the file if it is found locally, otherwise render the "disabled" tooltip.

Steps to test

Component test in DebugSpec.cy.tsx and e2e test in debug.cy.ts. I created a test-project locally with some run failures to fully test against.

How has the user experience changed?

Screen.Recording.2023-02-02.at.1.05.39.PM.mov

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@ZachJW34 ZachJW34 force-pushed the zachw/debug-open-ide branch from af4dcef to 6f36895 Compare February 2, 2023 19:25
@cypress
Copy link

cypress bot commented Feb 2, 2023 •
edited
Loading

8 flaky tests on run #43817 ↗︎

0 5100 74 0 Flakiness 8

Details:

fix test
Project: cypress Commit: 31bdc36828
Status: Passed Duration: 14:06 💡
Started: Feb 6, 2023 5:03 PM Ended: Feb 6, 2023 5:17 PM
Flakiness  e2e/origin/cookie_behavior.cy.ts • 4 flaky tests • 5x-driver-electron

View Output Video

Test
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test
... > correctly returns currentRetry
... > correctly returns currentRetry
... > correctly returns currentRetry
Flakiness  cypress/proxy-logging.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test
... > intercept log has consoleProps with intercept info

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

ZachJW34
ZachJW34 commented Feb 2, 2023
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
warrensplayer
warrensplayer requested changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall functionality looks good, just some particular UI items to address.

packages/app/src/debug/DebugSpec.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugSpec.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugSpec.vue
Comment on lines +25 to +28
<OpenFileInIDE
v-slot="{onClick}"
:file-path="specData.fullPath"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user opens the IDE and then returns to the app, the tooltip reshows itself. Can this be closed on click or I saw there is an auto-hide prop for the tooltip component we are using.

Screen.Recording.2023-02-03.at.10.15.51.AM.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is expected behavior. The tooltip shows on hover/focus, when you click back into the app the browser restores focus to the button, causing the tooltip to appear. You could probably workaround it, but I don't think the workaround would be worth the investment

packages/app/src/debug/DebugSpec.vue Outdated Show resolved Hide resolved
lmiller1990
lmiller1990 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment about the style, but the code and feature looks good. I won't block, since the comment is more style than anything else.

packages/app/cypress/e2e/debug.cy.ts Outdated Show resolved Hide resolved
warrensplayer
warrensplayer approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to establish more standards on UI interactions, like for tooltips in this story, so we can build them into components, etc and not have to continuously address them in PRs. The functionality here works as defined, so not going to hold up this PR at this time.

@ZachJW34 ZachJW34 merged commit f1b0e55 into develop Feb 6, 2023
@ZachJW34 ZachJW34 deleted the zachw/debug-open-ide branch February 6, 2023 17:22
tgriesser added a commit that referenced this pull request Feb 8, 2023
@tgriesser
Merge branch 'develop' into tgriesser/spike/spike
bdce6fe 
* develop: (28 commits)
  chore: update changelog validation example (#25742)
  fix: Improve error handling around calls to `this.next` in middleware (#25702)
  chore: debug page tooltip distance and artifact border (#25727)
  fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730)
  misc: Add max widths to debug page message states (#25725)
  chore: export types (#25714)
  chore: release @cypress/webpack-preprocessor-v5.16.3
  chore: release @cypress/vue-v5.0.4
  chore: release @cypress/grep-v3.1.4
  chore: Fix flaky test (#25726)
  dependency(deps): update dependency debug to ^4.3.4 🌟 (#25699)
  feat: openInIDE for failed debug spec (#25691)
  test: fix flaky CT test by relying on query (#25706)
  test: fix flaky migration test (#25672)
  misc: style change for responsiveness (#25687)
  misc: set min widths for icons (#25684)
  chore(deps): update dependency markdown-it to v11.0.1 🌟 (#25698)
  chore: Fix flaky origin .wait() test (#25693)
  chore: unskip tests (#25676)
  chore: release @cypress/webpack-preprocessor-v5.16.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@warrensplayer warrensplayer warrensplayer approved these changes

@marktnoonan marktnoonan Awaiting requested review from marktnoonan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IATR](M1.1) Open In IDE button for debug spec component header
3 participants
@ZachJW34 @warrensplayer @lmiller1990