-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing EventEmitter2 type to Cypress and cy + missing runUrl to Cypress.run() result. #6066
Added missing EventEmitter2 type to Cypress and cy + missing runUrl to Cypress.run() result. #6066
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bahmutov Fast-forwarded and fixed typo ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, merging
Thanks so much! Wasn't expecting such a fast turnaround on an issue. Amazing work |
User facing changelog
removeListener
,removeAllListeners
are added toCypress
andcy
.runUrl
is added to type.Additional details
Why was this change necessary?
on
oronce
,removeListener
andremoveAllListeners
are documented here. But their types didn't exist inindex.d.ts
.runUrl
is documented. But type is missing.What is affected by this change?
N/A
Any implementation details to explain?
eventemitter2
tocli
and usedimport()
inindex.d.ts
.How has the user experience changed?
#5228
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?