-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: version 0.2.0 → 1.0.0 #348
Conversation
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 95.62% 95.62%
=======================================
Files 56 56
Lines 3135 3135
=======================================
Hits 2998 2998
Misses 137 137
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, v1.0.0! I left a comment which may be way off-base (apologies if so).
Additional considerations:
- Clarifying for Version 1 release #330 closure: is step 2 accounted for? Mostly here this is a double check that we didn't need to cover more than the
poetry build
for PyPI / etc.
- Minting a release which should be built automatically
- I recognize it might be forthcoming but wanted to double check on Doc: Add section describing bump and release process #343. Would it make sense to add some material to this PR? Otherwise would a merge now mean the release docs material is technically a part of the next release and not this one?
Step 2 is accounted for and should happen automatically after drafting the new release.
I threw together a quick release guide (based on my anticipated next steps). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d33bs - are you able to give this a final look and approval when you're happy? It would be great for you to give this another look if you're able!
a46713e
to
c89d651
Compare
c89d651
to
d339bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the replies to the comments! I've added a few more thoughts to this review for your consideration.
d339bbf
to
72687f2
Compare
@d33bs This ready for review again. I've moved some of the changes you had questions about into separate branches that we can discuss after v1.0.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kenibrewer !
Description
v1.0.0 release of pycytominer
The changelog was initially generated with
cz bump --files-only
but was manually edited to add the changes that pre-dated adoption of the conventional commit standard.The changes added to the changelog are summaries of changes relevant to users and key dev processes rather than all changes.
Closes #330
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.