Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Audit Functionality #60

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Dec 4, 2019

Here I add the option to calculate full pairwise correlations. This is an alternative to calculating pairwise correlations in replicates, randomly shuffling metadata labels and calculating pairwise correlations to define a null, and reporting only median results.

In this pull request I add audit_resolution="full" as a function argument. The default remains audit_resolution="median".

I also address issue #58 (it was a pressing change!)

@codecov-io
Copy link

Codecov Report

Merging #60 into master will increase coverage by 0.09%.
The diff coverage is 98.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   96.69%   96.78%   +0.09%     
==========================================
  Files          38       38              
  Lines        1573     1618      +45     
==========================================
+ Hits         1521     1566      +45     
  Misses         52       52
Impacted Files Coverage Δ
pycytominer/feature_select.py 90% <0%> (-1.67%) ⬇️
pycytominer/tests/test_audit.py 100% <100%> (ø) ⬆️
...ominer/tests/test_cyto_utils/test_feature_infer.py 100% <100%> (ø) ⬆️
pycytominer/cyto_utils/features.py 78.26% <100%> (+2.07%) ⬆️
pycytominer/audit.py 97.26% <100%> (+2.66%) ⬆️
pycytominer/tests/test_feature_select.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e882e...b1f7693. Read the comment docs.

@gwaybio gwaybio merged commit 50233cf into cytomining:master Dec 4, 2019
@gwaybio gwaybio deleted the upgrade-audit branch December 4, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants