Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kwargs in feature_select #58

Closed
gwaybio opened this issue Dec 2, 2019 · 0 comments
Closed

Remove kwargs in feature_select #58

gwaybio opened this issue Dec 2, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@gwaybio
Copy link
Member

gwaybio commented Dec 2, 2019

Related to #48 (Maybe can be completed at the same time)

kwargs are very dangerous in feature_select and provide no benefit in this specific case. Just make them function arguments.

It prevents the case where operation = "correlation_threshold" and operations = "correlation_threshold". Both of these will not throw an error, but since the correct function argument is "operation", operations = "correlation_threshold" will actually perform feature selection with the "variance_threshold" default. This is not good!

@gwaybio gwaybio added bug Something isn't working enhancement New feature or request labels Dec 2, 2019
gwaybio added a commit to gwaybio/pycytominer that referenced this issue Dec 4, 2019
@gwaybio gwaybio closed this as completed in 50233cf Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant