Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs: Token deployer #564

Closed
7 tasks done
magentaceiba opened this issue May 19, 2023 · 1 comment
Closed
7 tasks done

Bugs: Token deployer #564

magentaceiba opened this issue May 19, 2023 · 1 comment
Assignees

Comments

@magentaceiba
Copy link
Contributor

magentaceiba commented May 19, 2023

Description (what needs to be done) / Expected Behavior

  • Bug: validation error persists after entering token address
  • adddressInputValidation.png
  • you don't need to have an address. If no address is inputted, the entire amount is minted to the address of the user who is logged in
  • notRequired.png
  • User experience issue: As a person deploying a token for the first time, at first in this screen there is a placeholder that says Token ID, but as soon as I paste the token address, that changes to 0 without a label. As a new user I wouldn't understand what that 0 is. I'd suggest we add labels underneath the fields, since about 10 users over time have asked us before what the token ID is.
  • tokenIdNeedsLabel.png
  • Token deployer: address fields are too narrow for full address to show. One solution is to show first part of address and ... last part of address.

Acceptance Criteria
validation errors listed above are addressed. Labels below entry boxes on token address, ID, FA2. Please check for any further issues in token deployer.

Supporting information (Figma link, notes, etc)

When finished, please add Link to the PR or completed Figma / design asset, as a comment to the ticket.

@fabiolalombardim
Copy link
Contributor

token ID label: "Homebase will only track your governance token at a certain ID index, which is a parameter specified upon deploying the token contract. Fungible tokens usually have the ID of 0 (zero)."

fabiolalombardim added a commit that referenced this issue May 25, 2023
This was referenced May 25, 2023
Man-Jain added a commit that referenced this issue May 25, 2023
* token deployment flow

* clean & validations added

* new design implemented

* ui upgrades

* Add Token contract deployment logic and connect with frontend

Signed-off-by: Manank Patni <manank321@gmail.com>

* success page added to the flow

* Add validation to the forms

Signed-off-by: Manank Patni <manank321@gmail.com>

* initial lite config removed

* tracking untracked assets

* merged develop, fixed token address validation & removed first step of creator

* label on token deployment success

* fixed duplicated error on failed launch

* fix validations & updated success page

* textbox css adjustments

* last bugs of #564

* fix total supply

---------

Signed-off-by: Manank Patni <manank321@gmail.com>
Co-authored-by: Manank Patni <manank321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants