Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token deployment flow #506

Merged
merged 24 commits into from
May 25, 2023
Merged

token deployment flow #506

merged 24 commits into from
May 25, 2023

Conversation

fabiolalombardim
Copy link
Contributor

@fabiolalombardim fabiolalombardim commented Feb 26, 2023

Closes #497
Closes #550
Closes #564

@netlify
Copy link

netlify bot commented Feb 26, 2023

Deploy Preview for tezos-homebase ready!

Name Link
🔨 Latest commit 47fe860
🔍 Latest deploy log https://app.netlify.com/sites/tezos-homebase/deploys/646fb4ed5ef4820008075188
😎 Deploy Preview https://deploy-preview-506--tezos-homebase.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fabiolalombardim
Copy link
Contributor Author

Closes #512

className={selectedTemplate === "lite" ? style.selected : ""}
>
<LiteIcon style={{ marginBottom: 14 }} />
<BoxTitle color="textSecondary">Lite DAO</BoxTitle>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lite dao shouldn't be here

@@ -85,7 +85,8 @@ const enabledForms: Record<
component: ({ open }) => <UpdateRegistryDialog open={open} />
}
],
"": []
"": [],
"lite": []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -66,7 +66,7 @@ export interface NavigationBarProps {
}
}

export type DAOTemplate = "lambda" | ""
export type DAOTemplate = "lambda" | "lite" | ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIte shouldn't be here

Copy link
Collaborator

@Man-Jain Man-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-21 at 3 38 03 PM

Can we redirect user directly to the Step two instead of showing this, this is a big unnecessary.

@Man-Jain
Copy link
Collaborator

Screenshot 2023-04-21 at 3 41 56 PM

Let's put a label besides the Token Address and make it super clear that this is the token Address

Something Like

Your Token Address - KT1A4bpidDyfsSBzac1tka7U9BS65FCK3HrG

@fabiolalombardim fabiolalombardim self-assigned this May 22, 2023
@Man-Jain
Copy link
Collaborator

Initial token distribution

  • Should not be able to allocate tokens to the same address multiple times
  • On allocating more than the total supply, the page hangs and you cannot change the fields

@Man-Jain Man-Jain merged commit 324cbb4 into develop May 25, 2023
@Man-Jain Man-Jain deleted the token-deployment-flow branch May 25, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants