Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-aws] split dagster_aws.pipes module into a package with submodules #23509

Merged

Conversation

danielgafni
Copy link
Contributor

@danielgafni danielgafni commented Aug 8, 2024

Summary & Motivation

Prepare for ECS pipes by organizing code into submodules. dagster_aws/pipes.py file grew too large already, splitting it will make development easier.

How I Tested These Changes

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 8, 2024
@danielgafni danielgafni marked this pull request as draft August 8, 2024 16:03
@danielgafni danielgafni changed the title [dagster-aws] refactor dagster aws.pipes module into a package [dagster-aws] refactor dagster_aws.pipes module into a package Aug 8, 2024
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 3a83b90 to 22f2ff4 Compare August 9, 2024 07:15
@danielgafni danielgafni changed the base branch from master to pipes-cloudwatch-message-reader-docs August 9, 2024 07:15
Copy link
Contributor Author

danielgafni commented Aug 9, 2024

@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch 2 times, most recently from 19b5674 to e6c0af2 Compare August 9, 2024 10:36
@danielgafni danielgafni marked this pull request as ready for review August 9, 2024 10:36
@danielgafni danielgafni changed the title [dagster-aws] refactor dagster_aws.pipes module into a package [dagster-aws] split dagster_aws.pipes module into a package with submodules Aug 9, 2024
@erinkcochran87 erinkcochran87 removed their request for review August 9, 2024 15:41
@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from e6b42c4 to d23e5d4 Compare August 9, 2024 17:16
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from e6c0af2 to 397d8eb Compare August 9, 2024 17:16
@danielgafni danielgafni changed the base branch from pipes-cloudwatch-message-reader-docs to master August 9, 2024 17:18
@danielgafni danielgafni changed the base branch from master to pipes-cloudwatch-message-reader-docs August 9, 2024 17:22
@danielgafni danielgafni removed the area: docs Related to documentation in general label Aug 9, 2024
@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from d23e5d4 to 8e5de4c Compare August 9, 2024 21:52
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 397d8eb to 34a8b46 Compare August 10, 2024 14:03
Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 2:19pm

Copy link

github-actions bot commented Aug 10, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-5rtrf683z-elementl.vercel.app
https://08-08-refactor-dagster-aws-pipes-module-into-a-package.core-storybook.dagster-docs.io

Built with commit a9842e4.
This pull request is being automatically deployed with vercel-action

@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from 8e5de4c to a9842e4 Compare August 10, 2024 14:16
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 46cb078 to 1537d9f Compare August 10, 2024 14:18
@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from a9842e4 to a90ac4c Compare August 16, 2024 14:04
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 1537d9f to 96640d4 Compare August 16, 2024 14:04
@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from a90ac4c to 79d16ab Compare August 16, 2024 15:47
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 96640d4 to f2197f5 Compare August 16, 2024 15:47
@danielgafni danielgafni force-pushed the pipes-cloudwatch-message-reader-docs branch from 79d16ab to b46fe9b Compare August 16, 2024 15:54
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from f2197f5 to 9339f59 Compare August 16, 2024 15:54
@danielgafni danielgafni changed the base branch from pipes-cloudwatch-message-reader-docs to graphite-base/23509 August 16, 2024 16:09
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 9339f59 to 633d4c6 Compare August 16, 2024 16:12
@danielgafni danielgafni changed the base branch from graphite-base/23509 to master August 16, 2024 16:12
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 633d4c6 to 5ada018 Compare August 16, 2024 21:30
@danielgafni danielgafni force-pushed the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch from 5ada018 to 2b5d54e Compare August 16, 2024 21:32
@danielgafni danielgafni merged commit fc26db2 into master Aug 17, 2024
1 check passed
@danielgafni danielgafni deleted the 08-08-refactor_dagster_aws.pipes_module_into_a_package branch August 17, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants