Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-aws] [docs] add documentation for ECS Pipes #23569

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[dagster-aws] [docs] add documentation for ECS Pipes #23569

merged 1 commit into from
Aug 28, 2024

Conversation

danielgafni
Copy link
Contributor

@danielgafni danielgafni commented Aug 10, 2024 •
edited
Loading

This PR adds examples for using Dagster Pipes with AWS ECS.

Summary & Motivation

How I Tested These Changes

@vercel Vercel
Copy link

vercel bot commented Aug 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 2:26pm

This was referenced Aug 10, 2024
Merged
Merged
Merged
@danielgafni Graphite App
Copy link
Contributor Author

danielgafni commented Aug 10, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danielgafni and the rest of your teammates on Graphite Graphite

@danielgafni danielgafni marked this pull request as ready for review August 10, 2024 14:26
@danielgafni danielgafni marked this pull request as draft August 10, 2024 14:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 10, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-m8fk1kdnc-elementl.vercel.app
https://08-10--dagster-aws-docs-add-documentation-for-ecs-pipes.dagster.dagster-docs.io

Direct link to changed pages:

@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from ef6bb27 to 945a5d3 Compare August 16, 2024 13:25
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from f0f5594 to 28cae5d Compare August 16, 2024 13:25
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 945a5d3 to de67177 Compare August 16, 2024 14:05
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 28cae5d to 6e0d6aa Compare August 16, 2024 14:05
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from de67177 to a1864e5 Compare August 16, 2024 15:47
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 6e0d6aa to 969a718 Compare August 16, 2024 15:48
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from a1864e5 to 592d340 Compare August 16, 2024 15:55
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 969a718 to 56c41a9 Compare August 16, 2024 15:55
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 592d340 to 76314fe Compare August 16, 2024 16:12
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 56c41a9 to a812f06 Compare August 16, 2024 16:13
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 76314fe to a76eaa6 Compare August 16, 2024 21:30
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from a812f06 to e0d8147 Compare August 16, 2024 21:30
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from a76eaa6 to 38144fb Compare August 16, 2024 21:32
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from e0d8147 to a07ac44 Compare August 16, 2024 21:32
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 38144fb to ed9a6a4 Compare August 19, 2024 21:16
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from a07ac44 to 86f068f Compare August 19, 2024 21:17
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from ed9a6a4 to 371d6bb Compare August 19, 2024 22:09
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 86f068f to 5738546 Compare August 19, 2024 22:09
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 371d6bb to 5233da0 Compare August 20, 2024 16:09
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 2c511ac to 4dd44ea Compare August 23, 2024 12:36
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch 2 times, most recently from 1659b92 to 2ad2041 Compare August 23, 2024 13:56
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch 2 times, most recently from 697ef45 to c62498b Compare August 23, 2024 13:58
cmpadden
cmpadden approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - pending possible change if boto3-stubs are used in place of TypedDict.

@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch 5 times, most recently from 27640c8 to f637780 Compare August 27, 2024 07:58
@danielgafni danielgafni mentioned this pull request Aug 27, 2024
Merged
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch 3 times, most recently from 9739823 to 7f389db Compare August 27, 2024 10:29
@danielgafni danielgafni mentioned this pull request Aug 27, 2024
Merged
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch from 7f389db to eac4e63 Compare August 28, 2024 07:52
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from c62498b to 4766627 Compare August 28, 2024 07:53
@danielgafni danielgafni mentioned this pull request Aug 28, 2024
Merged
2 tasks
@danielgafni danielgafni force-pushed the 08-09-_dagster-aws_add_ecs_pipes branch 2 times, most recently from a0f68ca to 25fb13f Compare August 28, 2024 16:15
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 4766627 to 679622b Compare August 28, 2024 16:15
@danielgafni Graphite App
Copy link
Contributor Author

danielgafni commented Aug 28, 2024 •
edited
Loading

Merge activity

  • Aug 28, 1:32 PM EDT: @danielgafni started a stack merge that includes this pull request via Graphite.
  • Aug 28, 1:37 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 28, 1:38 PM EDT: @danielgafni merged this pull request with Graphite.

@danielgafni danielgafni changed the base branch from 08-09-_dagster-aws_add_ecs_pipes to graphite-base/23569 August 28, 2024 17:33
@danielgafni danielgafni changed the base branch from graphite-base/23569 to master August 28, 2024 17:34
@danielgafni danielgafni force-pushed the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch from 679622b to a35b7d5 Compare August 28, 2024 17:36
@danielgafni danielgafni merged commit be8463a into master Aug 28, 2024
1 of 2 checks passed
@danielgafni danielgafni deleted the 08-10-_dagster-aws_docs_add_documentation_for_ecs_pipes branch August 28, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmpadden cmpadden cmpadden approved these changes

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielgafni @cmpadden