Skip to content

Commit

Permalink
fix(create-waku): downgrade ncc (#938)
Browse files Browse the repository at this point in the history
`@vercel/ncc@0.38.2` seems to break create-waku's `notifyUpdate`.

Here's the error log:
```
TypeError: undefined is not a function
    at notifyUpdate (file:///.../node_modules/create-waku/dist/index.js:30:110825)
```

@himself65 @ojj1123 do you think it's fixable?

In the meantime, let's downgrade `ncc`.
  • Loading branch information
dai-shi authored Oct 4, 2024
1 parent a583133 commit 2613e58
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/create-waku/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@types/fs-extra": "^11.0.4",
"@types/prompts": "^2.4.9",
"@types/tar": "^6.1.13",
"@vercel/ncc": "^0.38.2",
"@vercel/ncc": "0.38.1",
"fs-extra": "^11.2.0",
"kolorist": "^1.8.0",
"prompts": "^2.4.2",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2613e58

Please sign in to comment.