-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create-waku): downgrade ncc #938
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Is it fixed? or need any investigating? If so, how could I reproduce it? |
It's not fixed. If you update ncc to the latest version, you can reproduce it. If you check |
we can replace ncc to other bundler like tsup, bunchee or something, they are not using webpack, webpack has too many hakcs on imports |
I hope we can replace it with more lightweight one. What was the reason we need bundling in the first place again? |
@ojj1123 @himself65 just opened a new issue #973. |
oops, I forgot to keep the ncc version. the previous one: #938
@vercel/ncc@0.38.2
seems to break create-waku'snotifyUpdate
.Here's the error log:
@himself65 @ojj1123 do you think it's fixable?
In the meantime, let's downgrade
ncc
.