Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-waku): bundle into single file #330

Merged
merged 19 commits into from
Dec 29, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 29, 2023 7:26am

Copy link

codesandbox-ci bot commented Dec 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4676831:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

@himself65
Copy link
Contributor Author

himself65 commented Dec 29, 2023

I have to rename the file into index.ts, because the output entry will always be index.js.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some refactor ideas.

packages/create-waku/src/index.ts Outdated Show resolved Hide resolved
packages/create-waku/src/index.ts Outdated Show resolved Hide resolved
packages/create-waku/src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with https://github.com/vercel/ncc, but looks okay.

@dai-shi dai-shi merged commit b916c7a into dai-shi:main Dec 29, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants