Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve broken fixtures in dev dataset script for local Dandi #1722

Closed

Conversation

aaronkanzer
Copy link
Member

Validation for creation of Django objects was failing prior to changes when running:

docker-compose run --rm django ./manage.py create_dev_dandiset --owner your.email@email.com

This PR resolves errors within this script to ensure correct setup locally

@aaronkanzer aaronkanzer changed the title Resolve broken fixtures in fixtures script for local dev Dandi Resolve broken fixtures in dev dataset script for local Dandi Oct 20, 2023
@yarikoptic
Copy link
Member

Hi @aaronkanzer , thank you for the patch! As I see that there is a dedicated http://github.com/dandi/dandi-archive/blob/HEAD/dandiapi/api/tests/test_create_dev_dandiset.py and I see it passing recently

dandi@drogon:/mnt/backup/dandi/tinuous-logs/dandi-archive/2023/10$ git grep 'test_create_dev' 31
31/github/cron/20231031T002002/8d66efa/CI for backend/2226/2_test (test).txt:2023-10-31T00:24:06.3991432Z dandiapi/api/tests/test_create_dev_dandiset.py::test_create_dev_dandiset PASSED [ 36%]
31/github/cron/20231031T002002/8d66efa/CI for backend/2226/2_test (test).txt:2023-10-31T00:25:58.7490431Z dandiapi/api/tests/test_create_dev_dandiset.py: 1 warning
31/github/cron/20231031T002002/8d66efa/CI for backend/2226/test (test)/6_Run tests.txt:2023-10-31T00:24:06.3991380Z dandiapi/api/tests/test_create_dev_dandiset.py::test_create_dev_dandiset PASSED [ 36%]
31/github/cron/20231031T002002/8d66efa/CI for backend/2226/test (test)/6_Run tests.txt:2023-10-31T00:25:58.7490425Z dandiapi/api/tests/test_create_dev_dandiset.py: 1 warning

could you

  • elaborate on the failure (is it a new fail or something "introduced" recently?)
  • see if you can adjust/extend that test so it demonstrates prior issue which this PR fixes?

@waxlamp
Copy link
Member

waxlamp commented Nov 1, 2023

I second @yarikoptic's requests -- without knowing the exact failure you encountered, it's hard to review this and understand the added value. Thanks @aaronkanzer!

@yarikoptic
Copy link
Member

Ping @aaronkanzer to discover more of the reason here

@aaronkanzer
Copy link
Member Author

aaronkanzer commented Jan 11, 2024

Closing due to duplicative code in #1809

@yarikoptic @waxlamp if you wouldn't mind taking a look there, that would be great!

The exact failure that should answer #1722 (comment) is included in the description of the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants