Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stats log, count pending in foreign currencies, bumped Buxfer client and supported capabilities #338

Closed

Conversation

nisan-tagar
Copy link
Contributor

@nisan-tagar nisan-tagar commented Sep 3, 2024

  • Update the stats log format to support pending in foreign currency and updated transactions
  • Bumped Buxfer client version and added support for automatic transaction status updates (from pending to cleared).
  • Buxfer store to report updates, and pending transactions in foreign currency.

nisan-tagar and others added 28 commits April 25, 2024 08:42
Co-authored-by: Daniel Hauser <36034483+daniel-hauser@users.noreply.github.com>
Added Buxfer API integration with buxfer-ts-client package
specify the environment of the scrape action to have better secret env management
… store to update transactions such as status changes and description updates
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/storage/buxfer.ts Outdated Show resolved Hide resolved
…stats format method, added required foreign field to stats object.
@nisan-tagar nisan-tagar changed the title Added stats log to store interface, bumped Buxfer client and supported capabilities Update stats log, count pending in foreign currencies, bumped Buxfer client and supported capabilities Sep 4, 2024
@nisan-tagar
Copy link
Contributor Author

@daniel-hauser All change requests are now resolved, waiting for review. Thanks!

@daniel-hauser
Copy link
Owner

@nisan-tagar I looked at the save stat logic and i see that the code is duplicated in all storages so i refactored to have all logic and creation in one place in #341
In the same PR i added the number of completed foreign transaction to the main message instead of adding them to the stats.

src/utils/currency.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Hauser <36034483+daniel-hauser@users.noreply.github.com>
@nisan-tagar
Copy link
Contributor Author

nisan-tagar commented Sep 8, 2024

@daniel-hauser 341 looks good.
I will close this PR, and bump Buxfer 1.0.6 in a dedicated PR

@nisan-tagar nisan-tagar closed this Sep 8, 2024
@nisan-tagar nisan-tagar deleted the save-stats-buxfer-bump branch September 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants