Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/better stats message #341

Merged
merged 5 commits into from
Sep 8, 2024
Merged

Feat/better stats message #341

merged 5 commits into from
Sep 8, 2024

Conversation

daniel-hauser
Copy link
Owner

This pull request focuses on refactoring and improving the messages and storage modules by introducing a new saveStats module, updating test snapshots, and enhancing transaction summaries to include details about foreign transactions.
The most important changes include the creation of the saveStats module, modifications to the messages module, and updates to the storage implementations.

Refactoring and Enhancements:

  • New saveStats Module:

    • Introduced createSaveStats and statsString functions to handle the creation and formatting of save statistics. (src/saveStats.ts)
  • Modifications to messages Module:

    • Updated getSummaryMessages to include foreign currency transactions in the summary. (src/messages.ts)
    • Removed the saved function and moved related logic to the saveStats module. (src/messages.ts)
  • Updates to Storage Implementations:

    • Refactored AzureDataExplorerStorage and BuxferStorage to use the new createSaveStats function. (src/storage/azure-data-explorer.ts, src/storage/buxfer.ts) [1] [2]

Test Updates:

  • Snapshot Updates:

    • Adjusted test snapshots to reflect the changes in transaction summaries and save statistics. (src/__snapshots__/messages.test.ts.snap) [1] [2] [3]
  • Test Refactoring:

    • Refactored tests in messages.test.ts to use the new createSaveStats function and updated the test cases accordingly. (src/messages.test.ts) [1] [2] [3] [4] [5] [6] [7] [8]

Code Cleanup:

  • Removed Unused Imports:
    • Cleaned up unused imports in various files to improve code readability. (src/storage/azure-data-explorer.ts, src/storage/buxfer.ts, src/storage/index.ts) [1] [2] [3]

@daniel-hauser daniel-hauser merged commit b433fd0 into main Sep 8, 2024
4 checks passed
@daniel-hauser daniel-hauser deleted the feat/betterStatsCode branch September 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant