warning: manual implementation of an assign operation
   --> clicky-core/src/sys/ipod4g/mod.rs:467:25
    |
467 |                           addr = addr | 0x6000_f100;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: manual implementation of an assign operation
   --> clicky-core/src/sys/ipod4g/mod.rs:467:25
    |
467 |                           addr = addr | 0x6000_f100;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: manual implementation of an assign operation
   --> clicky-core/src/sys/ipod4g/mod.rs:467:25
    |
467 |                           addr = addr | 0x6000_f100;
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addr |= 0x6000_f100`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
    = note: `#[warn(clippy::assign_op_pattern)]` on by default
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this `impl` can be derived
  --> clicky-core/src/devices/platform/pp/intcon.rs:54:1
   |
54 | / impl Default for IrqKind {
55 | |     fn default() -> IrqKind {
56 | |         IrqKind::Unregistered
57 | |     }
58 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
   = help: remove the manual implementation...
help: ...and instead derive it...
   |
44 + #[derive(Default)]
45 | enum IrqKind {
   |
help: ...and mark the default variant
   |
45 ~     #[default]
46 ~     Unregistered,
   |

warning: unneeded `return` statement
   --> clicky-core/src/devices/platform/pp/flash.rs:113:18
    |
113 |             _ => return Err(Unimplemented)
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
113 |             _ => Err(Unimplemented)
    |                  ~~~~~~~~~~~~~~~~~~

warning: this block may be rewritten with the `?` operator
   --> clicky-core/src/devices/generic/ide/mod.rs:610:21
    |
610 | /                     if let Err(e) = self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await {
611 | |                         // XXX: actually set error bits
612 | |                         return Err(e);
613 | |                     }
    | |_____________________^ help: replace it with: `self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator
   --> clicky-core/src/devices/generic/ide/mod.rs:529:21
    |
529 | /                     if let Err(e) = self.blockdev.read_exact(self.iobuf.as_raw()).await {
530 | |                         // XXX: actually set error bits
531 | |                         return Err(e);
532 | |                     }
    | |_____________________^ help: replace it with: `self.blockdev.read_exact(self.iobuf.as_raw()).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator
   --> clicky-core/src/devices/generic/ide/mod.rs:521:21
    |
521 | /                     if let Err(e) = self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await {
522 | |                         // XXX: actually set error bits
523 | |                         return Err(e);
524 | |                     }
    | |_____________________^ help: replace it with: `self.blockdev.seek(io::SeekFrom::Start(offset * 512)).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator
   --> clicky-core/src/devices/generic/ide/mod.rs:386:17
    |
386 | /                 if let Err(e) = self.blockdev.write_all(self.iobuf.as_raw()).await {
387 | |                     // XXX: actually set error bits
388 | |                     return Err(e);
389 | |                 }
    | |_________________^ help: replace it with: `self.blockdev.write_all(self.iobuf.as_raw()).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

warning: this block may be rewritten with the `?` operator
   --> clicky-core/src/devices/generic/ide/mod.rs:334:21
    |
334 | /                     if let Err(e) = self.blockdev.read_exact(self.iobuf.as_raw()).await {
335 | |                         // XXX: actually set error bits
336 | |                         return Err(e);
337 | |                     }
    | |_____________________^ help: replace it with: `self.blockdev.read_exact(self.iobuf.as_raw()).await?;`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
    = note: `#[warn(clippy::question_mark)]` on by default

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> clicky-core/src/devices/generic/ide/mod.rs:289:13
    |
289 |             ((cyl * NUM_HEADS as u64 + head) * NUM_SECTORS as u64 + sector) as u64
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((cyl * NUM_HEADS as u64 + head) * NUM_SECTORS as u64 + sector)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting to the same type is unnecessary (`u32` -> `u32`)
  --> clicky-core/src/devices/generic/asanram.rs:70:28
   |
70 |             stub_val: Some(stub as u32),
   |                            ^^^^^^^^^^^ help: try: `stub`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: field `0` is never read
   --> clicky-core/src/devices/generic/ide/mod.rs:167:18
    |
167 |     DMAMultiWord(u8),
    |     ------------ ^^
    |     |
    |     field in this variant
    |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
    |
167 |     DMAMultiWord(()),
    |                  ~~

warning: field `0` is never read
   --> clicky-core/src/devices/generic/ide/mod.rs:166:19
    |
166 |     DMASingleWord(u8),
    |     ------------- ^^
    |     |
    |     field in this variant
    |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
    |
166 |     DMASingleWord(()),
    |                   ~~

warning: field `0` is never read
   --> clicky-core/src/devices/generic/ide/mod.rs:165:20
    |
165 |     PioFlowControl(u8),
    |     -------------- ^^
    |     |
    |     field in this variant
    |
    = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
    |
165 |     PioFlowControl(()),
    |                    ~~

warning: variable does not need to be mutable
   --> clicky-core/src/sys/ipod4g/mod.rs:470:26
    |
470 |                       let (mut addr, prot) = self.memcon.virt_to_phys(addr);
    |                            ----^^^^
    |                            |
    |                            help: remove this `mut`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: variable does not need to be mutable
   --> clicky-core/src/sys/ipod4g/mod.rs:470:26
    |
470 |                       let (mut addr, prot) = self.memcon.virt_to_phys(addr);
    |                            ----^^^^
    |                            |
    |                            help: remove this `mut`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: variable does not need to be mutable
   --> clicky-core/src/sys/ipod4g/mod.rs:470:26
    |
470 |                       let (mut addr, prot) = self.memcon.virt_to_phys(addr);
    |                            ----^^^^
    |                            |
    |                            help: remove this `mut`
...
531 | / mmap! {
532 | |     RAM {
533 | |         0x1000_0000..=0x11ff_ffff => sdram,
534 | |         0x4000_0000..=0x4001_7fff => fastram,
...   |
588 | |     }
589 | | }
    | |_- in this macro invocation
    |
    = note: `#[warn(unused_mut)]` on by default
    = note: this warning originates in the macro `impl_mem_r` which comes from the expansion of the macro `mmap` (in Nightly builds, run with -Z macro-backtrace for more info)