Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Romanian (ro) localization #70

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Added Romanian (ro) localization #70

merged 1 commit into from
Aug 4, 2023

Conversation

lainefox
Copy link
Contributor

@lainefox lainefox commented Aug 4, 2023

Translated the app into Romanian.

My first pull request... I hope I am doing this right.

@lainefox lainefox changed the title Added Romanian localization Added Romanian (ro) localization Aug 4, 2023
@danilkinkin
Copy link
Owner

Looks good, I'll try to merge the code as soon as possible and fix issues if I find it.

Thanks a lot for your work

@danilkinkin danilkinkin changed the base branch from master to dev August 4, 2023 21:01
@danilkinkin danilkinkin merged commit d09541c into danilkinkin:dev Aug 4, 2023
@danilkinkin
Copy link
Owner

Hi @lainefox, I have few questions, can you help?
It's correct translations?

<string name="wallet_title">Budget</string>
<string name="label_budget">Budget</string>
<string name="total_title">Total</string>

Also, about plural forms. Can you provide plural form few
key one applies for value 1
key few applies for values 0, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
key other applies for values 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32...

<plurals name="spends_today">
    <item quantity="one">%1$s cheltuit azi</item>
    <item quantity="few"></item>
    <item quantity="other">%1$s cheltuiți azi</item>
</plurals>
<plurals name="day">
    <item quantity="one">o zi</item>
    <item quantity="few"></item>
    <item quantity="other">%1$s zile</item>
</plurals>
<plurals name="finish_date_label">
    <item quantity="one">Până pe %1$s (o zi)</item>
    <item quantity="few"></item>
    <item quantity="other">Până pe %1$s (%2$s zile)</item>
</plurals>
<plurals name="finish_date">
    <item quantity="one">%1$s (o zi)</item>
    <item quantity="few"></item>
    <item quantity="other">%1$s (%2$s zile)</item>
</plurals>

@lainefox
Copy link
Contributor Author

lainefox commented Aug 5, 2023

It's correct translations?

Oh, sry, it should've been "Buget" instead of "Budget". "Total" is correct the way it is.

<string name="wallet_title">Buget</string>
<string name="label_budget">Buget</string>
<string name="total_title">Total</string>

Also, about plural forms. Can you provide plural form few

Yeah, the form used for other applies to few too in Romanian, so here's the final version:

<plurals name="spends_today">
    <item quantity="one">%1$s cheltuit azi</item>
    <item quantity="few">%1$s cheltuiți azi</item>
    <item quantity="other">%1$s cheltuiți azi</item>
</plurals>
<plurals name="day">
    <item quantity="one">o zi</item>
    <item quantity="few">%1$s zile</item>
    <item quantity="other">%1$s zile</item>
</plurals>
<plurals name="finish_date_label">
    <item quantity="one">Până pe %1$s (o zi)</item>
    <item quantity="few">Până pe %1$s (%2$s zile)</item>
    <item quantity="other">Până pe %1$s (%2$s zile)</item>
</plurals>
<plurals name="finish_date">
    <item quantity="one">%1$s (o zi)</item>
    <item quantity="few">%1$s (%2$s zile)</item>
    <item quantity="other">%1$s (%2$s zile)</item>
</plurals>

Sorry for the delay...

@danilkinkin
Copy link
Owner

Thanks

@danilkinkin
Copy link
Owner

Added in release v.3.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants