Normalize path arguments (#84)

-Trim extra `'`
danvk · Apr 10, 2019 · 5e018d3 · 5e018d3
1 parent b036e59
commit 5e018d3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/src/cli.ts b/src/cli.ts
@@ -20,8 +20,7 @@ interface Arguments {
 }
 
 function parseArguments(): Arguments {
-  // TODO: Use `middleware` to remove extra single quotes from positional arguments
-  return yargs
+  const argv = yargs
     .strict()
     .scriptName('source-map-explorer')
     .usage('Analyze and debug space usage through source maps.')
@@ -94,6 +93,12 @@ function parseArguments(): Arguments {
       return true;
     })
     .parse();
+
+  // Trim extra quotes
+  const quoteRegex = /'/g;
+  argv._ = argv._.map(path => path.replace(quoteRegex, ''));
+
+  return argv;
 }
 
 /**

diff --git a/tests/cli.test.js b/tests/cli.test.js
@@ -20,8 +20,8 @@ describe('CLI', function() {
     }
   });
 
-  it('should print result as JSON', async function() {
-    const result = await execute(SCRIPT_PATH, ['data/foo.min.inline-map.js', '--json']);
+  it('should print result as JSON and support path wrapped by quotes', async function() {
+    const result = await execute(SCRIPT_PATH, ["'data/foo.min.inline-map.js'", '--json']);
 
     expect(result).to.matchSnapshot();
   });

diff --git a/tests/cli.test.js.snap b/tests/cli.test.js.snap
@@ -85,7 +85,7 @@ exports[`CLI should output result as tsv 1`] = `
 "
 `;
 
-exports[`CLI should print result as JSON 1`] = `
+exports[`CLI should print result as JSON and support path wrapped by quotes 1`] = `
 "{
   \\"node_modules/browserify/node_modules/browser-pack/_prelude.js\\": 463,
   \\"dist/bar.js\\": 2854,