Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running with *.js and '*.js' (quoted) should behave the same #84

Closed
danvk opened this issue Feb 14, 2019 · 3 comments
Closed

Running with *.js and '*.js' (quoted) should behave the same #84

danvk opened this issue Feb 14, 2019 · 3 comments
Assignees
@nikolay-borzov
Labels
🚀 enhancement

Comments

@danvk
Copy link
Owner

danvk commented Feb 14, 2019

I got quite confused when I tried to run:

$ source-map-explorer *.js
Usage:
  source-map-explorer <script.js> [<script.js.map>]
  source-map-explorer [--json | --html | --tsv] [-m | --only-mapped] <script.js> [<script.js.map>] [--replace=BEFORE --with=AFTER]... [--noroot]
  source-map-explorer -h | --help | --version

in a directory with 4 bundles. It just shows the usage.

The solution was to run with '*.js' (quoted):

$ source-map-explorer '*.js'

These should do the same thing.
@nikolay-borzov nikolay-borzov self-assigned this Feb 21, 2019
@nikolay-borzov
Copy link
Collaborator

Have you tried source-map-explorer *.js on Unix system?

@nikolay-borzov
Copy link
Collaborator

Here is how source-map-explorer './testdata/*.*' is parsed on windows:

 '<script.js>': '\'./testdata/*.*\''

Perhaps we should try another argument parser?

nikolay-borzov added a commit that referenced this issue Feb 21, 2019
@nikolay-borzov
Running with *.js and '*.js' (quoted) should behave the same (#84)
8df9921 
- Normalize `<script.js>` and `<script.js.map>` paths. '\'./js/foo.min.js\'' => './js/foo.min.js'
- Update dependencies

resolves #84
This was referenced Feb 21, 2019
Closed
Merged
nikolay-borzov added a commit that referenced this issue Mar 11, 2019
@nikolay-borzov
Running with *.js and '*.js' (quoted) should behave the same (#84)
a1fede5 
- Normalize `<script.js>` and `<script.js.map>` paths. '\'./js/foo.min.js\'' => './js/foo.min.js'
- Update dependencies

resolves #84
This was referenced Mar 31, 2019
Closed
Closed
@nikolay-borzov
Copy link
Collaborator

Addess #106

@nikolay-borzov nikolay-borzov mentioned this issue Apr 7, 2019
Closed
nikolay-borzov added a commit that referenced this issue Apr 10, 2019
@nikolay-borzov
Normalize path arguments (#84)
5e018d3 
-Trim extra `'`
@nikolay-borzov nikolay-borzov mentioned this issue Apr 10, 2019
Merged
nikolay-borzov added a commit that referenced this issue Apr 13, 2019
@nikolay-borzov
Support multiple file tokens (#84)
31630ba 
- Expand multiple globs
- Accept mutiple file tokens - file names or globs
nikolay-borzov added a commit that referenced this issue Apr 13, 2019
@nikolay-borzov
Normalize path arguments (#84)
c8b6640 
- Trim extra `'`
- Expand multiple globs
- Accept multiple file tokens - file names or globs
nikolay-borzov added a commit that referenced this issue Apr 28, 2019
@nikolay-borzov
Normalize path arguments (#84)
7b6d7ff 
- Trim extra `'`
- Expand multiple globs
- Accept multiple file tokens - file names or globs
@nikolay-borzov nikolay-borzov mentioned this issue Apr 28, 2019
Merged
nikolay-borzov added a commit that referenced this issue May 6, 2019
@nikolay-borzov
Normalize path arguments (#84)
c38e61d 
- Trim extra `'`
- Expand multiple globs
- Accept multiple file tokens - file names or globs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikolay-borzov nikolay-borzov

Labels
🚀 enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danvk @nikolay-borzov