-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server restarts using pub workspaces #3721
Comments
I think this is the main problem build/build_runner_core/lib/src/generate/build_definition.dart Lines 105 to 106 in b3d3ef1
This is already broken for some non-standard setups if the file isn't at exactly the hardcoded path. We could fix this for unexpected paths under the root package, but as Jake mentioned this causes a problem when the package config is outside of any package. My first hacky idea is to add a synthetic package for this, I think we discover the package config when building the package graph so we should have the information we need. We'll also need to communicate that path through to the above lines, so we probably need to add it as another field on both |
True, we could go the synthetic package route similar to how we handle SDK sources. Not sure what we want to call it, |
Hmm, build_runner doesn't work at all for packages using pub workspaces. build/build_runner_core/lib/src/package_graph/package_graph.dart Lines 221 to 227 in 039aeca
I'm not sure how we wouldn't have hit this earlier though... |
Use non-workspace resolution because `build_runner` does not support packages where the `pubspec.lock` file is not at the package root. See dart-lang/build#3721
This was a local issue, I still had some |
I think this is done. |
Sorry - I misread what this issue was about. We probably still should do this. |
Currently one has to manually restart build_runner on each
pub get
when using workspaces.Context being discussed in #3717
The text was updated successfully, but these errors were encountered: